TRT-1989: schema migration for non gorm based tables#3518
Open
neisw wants to merge 8 commits into
Open
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@neisw: This pull request references TRT-1989 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
Contributor
Author
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neisw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds an embedded SQL migrations set, a migration orchestrator package with runtime and CLI controls (run/version/force/down), runs migrations during DB initialization, removes runtime partitioned-table sync, updates go.mod, and adds E2E migration tests and test migrations. ChangesVersioned Migration System
Sequence DiagramsequenceDiagram
actor Operator as Operator
participant CLI as CLI (cmd/sippy/migrate.go)
participant App as App (pkg/db/db.go)
participant Orchestrator as Migrate (pkg/db/migrate)
participant FS as Embedded SQL (pkg/db/migrations.FS)
participant PG as PostgreSQL
rect rgba(173, 216, 230, 0.5)
Note over Operator,PG: Startup migration flow
Operator->>App: start / UpdateSchema()
App->>Orchestrator: RunMigrations(db)
Orchestrator->>PG: Inspect schema_migrations
alt legacy schema detected
Orchestrator->>PG: Stamp baseline version
end
Orchestrator->>FS: Load embedded SQL files
Orchestrator->>PG: Execute Up() migrations
Orchestrator-->>App: return success/failure
App-->>Operator: startup complete
end
rect rgba(144, 238, 144, 0.5)
Note over Operator,PG: CLI inspection
Operator->>CLI: sippy migrate version
CLI->>Orchestrator: CurrentVersion(db)
Orchestrator->>PG: Query schema_migrations
Orchestrator-->>CLI: version: <n>, dirty: <bool>
CLI-->>Operator: print result
end
rect rgba(255, 192, 203, 0.5)
Note over Operator,PG: CLI force/down
Operator->>CLI: sippy migrate force 1
CLI->>Orchestrator: ForceVersion(db,1)
Orchestrator->>PG: Update schema_migrations entry
Orchestrator-->>CLI: forced migration version to 1
Operator->>CLI: sippy migrate down 2
CLI->>Orchestrator: MigrateDown(db,2)
Orchestrator->>PG: Steps(-2)
Orchestrator-->>CLI: rolled back 2 migration(s)
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~55 minutes 🚥 Pre-merge checks | ✅ 14 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (14 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
cmd/sippy/migrate.go (1)
63-67: 💤 Low valueConsider validating version is non-negative.
The
forcecommand accepts any integer, including negative values. While golang-migrate may reject invalid versions internally, providing upfront validation with a clear error message improves user experience.♻️ Suggested validation
version, err := strconv.Atoi(args[0]) if err != nil { return errors.WithMessage(err, "invalid version number") } + if version < -1 { + return errors.New("version must be -1 or greater (-1 resets to no migrations)") + }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@cmd/sippy/migrate.go` around lines 63 - 67, The RunE handler that parses the target migration version (using strconv.Atoi on args[0] in the RunE function for the force command) should validate the parsed integer is non-negative; after converting version, check if version < 0 and return an error (e.g., errors.WithMessagef or errors.New) with a clear message like "invalid version: must be non-negative" so negative values are rejected before calling golang-migrate.pkg/db/migrate/migrate.go (1)
104-106: 💤 Low valueIgnored errors from
m.Close()in deferred calls.The
Close()method returns two errors (sourceErr, dbErr) that are discarded in the deferred calls. While this is common for cleanup, in Lines 90-96 you explicitly check these errors but here they're ignored. For consistency and to avoid masking issues, consider logging any close errors.♻️ Suggested improvement to log close errors
defer func() { - m.Close() + srcErr, dbErr := m.Close() + if srcErr != nil { + log.WithError(srcErr).Warn("failed to close migration source") + } + if dbErr != nil { + log.WithError(dbErr).Warn("failed to close migration db driver") + } }()🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pkg/db/migrate/migrate.go` around lines 104 - 106, The deferred cleanup currently discards errors from m.Close(); change the defer to call sourceErr, dbErr := m.Close() and log any non-nil errors instead of ignoring them (e.g. if sourceErr != nil || dbErr != nil { log.Printf("m.Close errors: sourceErr=%v dbErr=%v", sourceErr, dbErr) }), keeping the same deferred anonymous func and referencing the m.Close() call.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cmd/sippy/migrate.go`:
- Around line 48-51: sippymigrate.CurrentVersion can return
migrate.ErrNilVersion for databases with no migrations; update the error
handling after calling sippymigrate.CurrentVersion(dbc.DB) to detect this case
(using errors.Is(err, migrate.ErrNilVersion) or direct comparison) and handle it
by returning or printing a clear "no migrations applied yet" message (or
treating version as zero/empty) instead of returning the error; change the
branch where you currently return errors.WithMessage(err, "could not get
migration version") to specially handle migrate.ErrNilVersion and only
wrap/return other errors.
---
Nitpick comments:
In `@cmd/sippy/migrate.go`:
- Around line 63-67: The RunE handler that parses the target migration version
(using strconv.Atoi on args[0] in the RunE function for the force command)
should validate the parsed integer is non-negative; after converting version,
check if version < 0 and return an error (e.g., errors.WithMessagef or
errors.New) with a clear message like "invalid version: must be non-negative" so
negative values are rejected before calling golang-migrate.
In `@pkg/db/migrate/migrate.go`:
- Around line 104-106: The deferred cleanup currently discards errors from
m.Close(); change the defer to call sourceErr, dbErr := m.Close() and log any
non-nil errors instead of ignoring them (e.g. if sourceErr != nil || dbErr !=
nil { log.Printf("m.Close errors: sourceErr=%v dbErr=%v", sourceErr, dbErr) }),
keeping the same deferred anonymous func and referencing the m.Close() call.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 898f5524-2be7-4ba1-8b70-aa2f14f331be
⛔ Files ignored due to path filters (292)
go.sumis excluded by!**/*.sum,!go.sumvendor/cel.dev/expr/.bazelversionis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/.gitattributesis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/BUILD.bazelis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/CONTRIBUTING.mdis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/GOVERNANCE.mdis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/MAINTAINERS.mdis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/MODULE.bazelis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/README.mdis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/WORKSPACEis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/WORKSPACE.bzlmodis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/checked.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cel.dev/expr/cloudbuild.yamlis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/eval.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cel.dev/expr/explain.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cel.dev/expr/regen_go_proto.shis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/regen_go_proto_canonical_protos.shis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/syntax.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cel.dev/expr/value.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/CHANGES.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/README.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/auth.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/compute.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/detect.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/filetypes.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/externalaccount/aws_provider.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/externalaccount/externalaccount.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/externalaccount/url_provider.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/externalaccount/x509_provider.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/externalaccountuser/externalaccountuser.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/gdch/gdch.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/impersonate/idtoken.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/impersonate/impersonate.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/stsexchange/sts_exchange.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/selfsignedjwt.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/grpctransport/directpath.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/grpctransport/grpctransport.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/httptransport/httptransport.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/httptransport/trace.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/httptransport/transport.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/compute/compute.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/compute/manufacturer.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/compute/manufacturer_linux.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/compute/manufacturer_windows.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/credsfile/filetype.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/internal.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/jwt/jwt.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/transport/cba.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/transport/cert/enterprise_cert.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/transport/cert/secureconnect_cert.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/transport/cert/workload_cert.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/transport/s2a.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/transport/transport.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/oauth2adapt/CHANGES.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/oauth2adapt/oauth2adapt.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/threelegged.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/CHANGES.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/arrow.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/bigquery.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/copy.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/dataset.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/doc.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/external.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/extract.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/inserter.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/internal/version.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/iterator.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/job.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/load.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/model.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/options.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/params.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/query.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/routine.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/auxiliary.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/auxiliary_go123.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/big_query_read_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/big_query_write_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/doc.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/helpers.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/annotations.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/arrow.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/avro.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/protobuf.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/storage.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/stream.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/table.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage_iterator.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/table.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/value.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/civil/civil.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/CHANGES.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/log.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/metadata.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/retry_linux.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/syscheck.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/syscheck_linux.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/syscheck_windows.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/iam/CHANGES.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/iam/apiv1/iampb/iam_policy.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/iam/apiv1/iampb/options.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/iam/apiv1/iampb/policy.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/iam/apiv1/iampb/resource_policy_member.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/internal/.repo-metadata-full.jsonis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/internal/detect/detect.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/internal/trace/trace.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/internal/uid/uid.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/alert_policy_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/auxiliary.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/auxiliary_go123.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/doc.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/gapic_metadata.jsonis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/group_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/helpers.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/metric_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/alert.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/alert_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/common.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/dropped_labels.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/group.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/group_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/metric.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/metric_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/mutation_record.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/notification.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/notification_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/query_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/service_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/snooze.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/snooze_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/span_context.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/uptime.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/uptime_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/notification_channel_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/query_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/service_monitoring_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/snooze_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/uptime_check_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/version.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/internal/version.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/CHANGES.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/TESTING.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/acl.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/bucket.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/doc.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/dynamic_delay.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/emulator_test.shis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/experimental/experimental.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/grpc_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/grpc_dp.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/grpc_metrics.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/grpc_reader.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/grpc_reader_multi_range.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/grpc_writer.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/hmac.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/http_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/iam.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/internal/apiv2/auxiliary.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/internal/apiv2/auxiliary_go123.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/internal/apiv2/doc.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/internal/apiv2/gapic_metadata.jsonis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/internal/apiv2/helpers.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/internal/apiv2/storage_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/internal/apiv2/storagepb/storage.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/internal/experimental.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/internal/version.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/invoke.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/notifications.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/option.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/reader.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/storage.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/trace.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/writer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp/app_engine.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp/bms.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp/detector.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp/faas.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp/gce.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp/gke.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/cloudmonitoring.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/constants.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/error.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/metric.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/option.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/version.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping/resourcemapping.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/udpa/annotations/migrate.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/udpa/annotations/migrate.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/udpa/annotations/security.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/udpa/annotations/security.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/udpa/annotations/sensitive.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/udpa/annotations/sensitive.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/udpa/annotations/status.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/udpa/annotations/status.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/udpa/annotations/versioning.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/udpa/annotations/versioning.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/udpa/type/v1/typed_struct.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/udpa/type/v1/typed_struct.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/annotations/v3/migrate.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/annotations/v3/migrate.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/annotations/v3/security.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/annotations/v3/security.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/annotations/v3/sensitive.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/annotations/v3/sensitive.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/annotations/v3/status.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/annotations/v3/status.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/annotations/v3/versioning.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/annotations/v3/versioning.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/authority.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/authority.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/cidr.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/cidr.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/collection_entry.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/collection_entry.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/context_params.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/context_params.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/extension.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/extension.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/resource.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/resource.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/resource_locator.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/resource_locator.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/resource_name.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/resource_name.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/data/orca/v3/orca_load_report.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/data/orca/v3/orca_load_report.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/service/orca/v3/orca.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/service/orca/v3/orca.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/service/orca/v3/orca_grpc.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/cel.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/cel.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/domain.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/domain.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/http_inputs.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/http_inputs.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/ip.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/ip.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/matcher.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/matcher.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/range.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/range.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/regex.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/regex.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/string.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/string.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/v3/cel.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/v3/cel.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/v3/range.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/v3/range.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/v3/typed_struct.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/cncf/xds/go/xds/type/v3/typed_struct.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/certs.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/certs.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/certs_vtproto.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/clusters.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/clusters.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/clusters_vtproto.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/config_dump.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/config_dump.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/config_dump_shared.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/config_dump_shared.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/config_dump_shared_vtproto.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/config_dump_vtproto.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/init_dump.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/init_dump.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/init_dump_vtproto.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/listeners.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/listeners.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/listeners_vtproto.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/memory.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/memory.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/memory_vtproto.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/metrics.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/metrics.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/metrics_vtproto.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/mutex_stats.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/mutex_stats.pb.validate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/mutex_stats_vtproto.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**
📒 Files selected for processing (8)
cmd/sippy/migrate.gogo.modpkg/db/db.gopkg/db/migrate/migrate.gopkg/db/migrations/000001_create_test_analysis_by_job_by_dates.down.sqlpkg/db/migrations/000001_create_test_analysis_by_job_by_dates.up.sqlpkg/db/migrations/migrations.gopkg/db/partitionedtables.go
💤 Files with no reviewable changes (1)
- pkg/db/partitionedtables.go
Contributor
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 157: Update the indirect dependency line for google.golang.org/grpc to
v1.79.3 or later to resolve the GHSA-p77j-4mvh-x3m3 authorization bypass; run
`go get google.golang.org/grpc@v1.79.3` (or newer) and then `go mod tidy` to
update go.mod/go.sum, and verify the module entry for google.golang.org/grpc now
shows v1.79.3+ (or later) so the vulnerable v1.74.2 is removed.
- Line 141: The go.mod entry for the OpenTelemetry SDK pins a vulnerable version
(go.opentelemetry.io/otel/sdk v1.36.0); update that module to v1.43.0 or later
(e.g., replace with go.opentelemetry.io/otel/sdk v1.43.0), then run go get/go
mod tidy to refresh go.sum and ensure all transitive dependencies are updated;
afterwards run your test/build pipeline to confirm nothing breaks.
- Line 14: Update the migrate dependency from
github.com/golang-migrate/migrate/v4 v4.19.1 to v4.19.2 in go.mod and refresh
modules; change the version string for the module
github.com/golang-migrate/migrate/v4 to v4.19.2 and then run the Go tooling
(e.g., go get github.com/golang-migrate/migrate/v4@v4.19.2 and go mod tidy or go
mod download) to update go.sum and ensure the new version is resolved.
- Line 13: The go-git dependency is pinned at a vulnerable version
(github.com/go-git/go-git/v5 v5.12.0); update the module declaration for
github.com/go-git/go-git/v5 to v5.19.0 and then run the module update (eg. go
get github.com/go-git/go-git/v5@v5.19.0 and go mod tidy) to refresh go.sum and
ensure transitive deps are resolved; after updating, run the test suite and a
build to confirm no API breakages and adjust any call sites if needed.
- Line 102: The project depends on a vulnerable module
github.com/jackc/pgproto3/v2 (v2.3.3) declared in go.mod; update the dependency
to a patched version as soon as one is released (replace the version string in
the go.mod require directive for github.com/jackc/pgproto3/v2) or, until a patch
exists, mitigate by replacing direct usage with a safer alternative (e.g., use a
vetted fork or add connection-level timeouts/retries in PostgreSQL client code
such as where pgx/pgproto3 is constructed) and add a comment and TODO in go.mod
to monitor upstream for a fixed release.
- Line 11: Update the three vulnerable module versions in go.mod: bump
github.com/apache/thrift from v0.17.0 to v0.23.0 or later,
github.com/go-jose/go-jose/v4 from v4.0.5 to v4.1.4 or later, and
go.opentelemetry.io/otel from v1.37.0 to v1.41.0 or later; after updating the
module versions in go.mod (referencing the module names
github.com/apache/thrift, github.com/go-jose/go-jose/v4, and
go.opentelemetry.io/otel), run module resolution (go get / go mod tidy) to
update go.sum and verify builds/tests pass.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 7876ac64-38e0-46c1-88c5-19603daec50b
📒 Files selected for processing (2)
go.modpkg/db/migrate/migrate.go
🚧 Files skipped from review as they are similar to previous changes (1)
- pkg/db/migrate/migrate.go
| github.com/glycerine/golang-fisher-exact v0.0.0-20230401153517-53168ae38651 | ||
| github.com/go-git/go-git/v5 v5.12.0 | ||
| github.com/google/go-cmp v0.6.0 | ||
| github.com/golang-migrate/migrate/v4 v4.19.1 |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
What is the latest version of github.com/golang-migrate/migrate/v4 and are there any security vulnerabilities in v4.19.1?
💡 Result:
Latest version of github.com/golang-migrate/migrate/v4 (as of 2026-05-11): v4.19.2 (published 2026-03-11) [1]. Are there any security vulnerabilities in v4.19.1? Yes—at least one public security report indicates the v4.19.1 Docker image has multiple HIGH/CRITICAL vulnerabilities reported by Trivy, which were attributed to the Go standard library and other bundled components, not to a specific flaw in migrate’s migration logic itself [2]. Additionally, a v4.19.1-related report (Trivy scan) lists multiple CVEs affecting the image’s dependency set (again largely tied to the Go toolchain/stdlib and other components) [3]. What’s the official stance from the project? The project’s security page states there are currently no published security advisories, and it provides guidance for reporting vulnerabilities via GitHub security advisories [4]. So, while there is no project-published security advisory specific to v4.19.1, third-party scanning discussions/issues report multiple vulnerabilities present in the v4.19.1 build artifacts/images [2][3].
Citations:
- 1: https://pkg.go.dev/github.com/golang-migrate/migrate/v4
- 2: Security Issue: Docker image v4.19.1 has 2 CRITICAL and 6 HIGH vulnerabilities golang-migrate/migrate#1381
- 3: Multiple CVEs reported by Trivy scan tool for latest version 4.19.1 golang-migrate/migrate#1332
- 4: https://github.com/golang-migrate/migrate/security
Upgrade golang-migrate to v4.19.2.
v4.19.1 is outdated; v4.19.2 is the current stable release (published March 2026). Additionally, v4.19.1 has reported HIGH/CRITICAL vulnerabilities in its build artifacts according to third-party scanning tools, primarily affecting bundled dependencies. Update to v4.19.2 to address both version staleness and known security concerns.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 14, Update the migrate dependency from
github.com/golang-migrate/migrate/v4 v4.19.1 to v4.19.2 in go.mod and refresh
modules; change the version string for the module
github.com/golang-migrate/migrate/v4 to v4.19.2 and then run the Go tooling
(e.g., go get github.com/golang-migrate/migrate/v4@v4.19.2 and go mod tidy or go
mod download) to update go.sum and ensure the new version is resolved.
| github.com/jackc/pgproto3/v2 v2.1.1 // indirect | ||
| github.com/jackc/pgservicefile v0.0.0-20200714003250-2b9c44734f2b // indirect | ||
| github.com/jackc/pgx/v4 v4.13.0 // indirect | ||
| github.com/jackc/pgproto3/v2 v2.3.3 // indirect |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check for patched versions of pgproto3
gh api graphql -f query='
{
securityVulnerabilities(first: 5, ecosystem: GO, package: "github.com/jackc/pgproto3/v2") {
nodes {
advisory {
summary
severity
}
vulnerableVersionRange
firstPatchedVersion {
identifier
}
}
}
}'Repository: openshift/sippy
Length of output: 643
Address HIGH severity denial of service vulnerability in pgproto3.
The github.com/jackc/pgproto3/v2 v2.3.3 dependency has a confirmed HIGH severity denial of service vulnerability with no available patch. This affects Sippy's PostgreSQL connectivity and availability. Monitor for upstream patches and consider upgrading as soon as a fixed version is released.
🧰 Tools
🪛 OSV Scanner (2.3.8)
[HIGH] 102-102: github.com/jackc/pgproto3/v2 2.3.3: Denial of service in github.com/jackc/pgproto3/v2
(GO-2026-4518)
[HIGH] 102-102: github.com/jackc/pgproto3/v2 2.3.3: Denial of service in github.com/jackc/pgproto3/v2
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 102, The project depends on a vulnerable module
github.com/jackc/pgproto3/v2 (v2.3.3) declared in go.mod; update the dependency
to a patched version as soon as one is released (replace the version string in
the go.mod require directive for github.com/jackc/pgproto3/v2) or, until a patch
exists, mitigate by replacing direct usage with a safer alternative (e.g., use a
vetted fork or add connection-level timeouts/retries in PostgreSQL client code
such as where pgx/pgproto3 is constructed) and add a comment and TODO in go.mod
to monitor upstream for a fixed release.
neisw
force-pushed
the
golang-migrate
branch
2 times, most recently
from
7ddb380 to
35bf135
Compare
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
cmd/sippy/migrate.go (1)
48-51:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winHandle
ErrNilVersionfor fresh databases.When no migrations have been applied yet,
CurrentVersionreturnsmigrate.ErrNilVersion(as seen inpkg/db/migrate/migrate.goline 138 where it directly returnsm.Version()). This causes the command to fail with "could not get migration version" instead of displaying a user-friendly message.🐛 Proposed fix to handle ErrNilVersion
+ "github.com/golang-migrate/migrate/v4" "github.com/pkg/errors"version, dirty, err := sippymigrate.CurrentVersion(dbc.DB) - if err != nil { + if err == migrate.ErrNilVersion { + fmt.Println("no migrations applied yet") + return nil + } else if err != nil { return errors.WithMessage(err, "could not get migration version") }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@cmd/sippy/migrate.go` around lines 48 - 51, sippymigrate.CurrentVersion can return migrate.ErrNilVersion for a fresh DB; update the error handling around the call in migrate.go (the block that calls sippymigrate.CurrentVersion(dbc.DB)) to detect errors.Is(err, migrate.ErrNilVersion) and handle it as a non-fatal case by emitting a user-friendly message like "no migrations have been applied yet" (or similar) and proceeding appropriately instead of returning an error; keep the existing behavior for other errors by returning errors.WithMessage(err, "could not get migration version").
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@cmd/sippy/migrate.go`:
- Around line 48-51: sippymigrate.CurrentVersion can return
migrate.ErrNilVersion for a fresh DB; update the error handling around the call
in migrate.go (the block that calls sippymigrate.CurrentVersion(dbc.DB)) to
detect errors.Is(err, migrate.ErrNilVersion) and handle it as a non-fatal case
by emitting a user-friendly message like "no migrations have been applied yet"
(or similar) and proceeding appropriately instead of returning an error; keep
the existing behavior for other errors by returning errors.WithMessage(err,
"could not get migration version").
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 9ce28e7b-9e16-407b-a8c3-51d9fde942b9
⛔ Files ignored due to path filters (151)
go.sumis excluded by!**/*.sum,!go.sumvendor/cel.dev/expr/.bazelversionis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/.gitattributesis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/BUILD.bazelis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/CONTRIBUTING.mdis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/GOVERNANCE.mdis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/MAINTAINERS.mdis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/MODULE.bazelis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/README.mdis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/WORKSPACEis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/WORKSPACE.bzlmodis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/checked.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cel.dev/expr/cloudbuild.yamlis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/eval.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cel.dev/expr/explain.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cel.dev/expr/regen_go_proto.shis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/regen_go_proto_canonical_protos.shis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/syntax.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cel.dev/expr/value.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/CHANGES.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/README.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/auth.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/compute.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/detect.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/filetypes.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/externalaccount/aws_provider.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/externalaccount/externalaccount.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/externalaccount/url_provider.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/externalaccount/x509_provider.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/externalaccountuser/externalaccountuser.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/gdch/gdch.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/impersonate/idtoken.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/impersonate/impersonate.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/stsexchange/sts_exchange.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/selfsignedjwt.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/grpctransport/directpath.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/grpctransport/grpctransport.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/httptransport/httptransport.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/httptransport/trace.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/httptransport/transport.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/compute/compute.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/compute/manufacturer.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/compute/manufacturer_linux.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/compute/manufacturer_windows.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/credsfile/filetype.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/internal.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/jwt/jwt.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/transport/cba.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/transport/cert/enterprise_cert.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/transport/cert/secureconnect_cert.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/transport/cert/workload_cert.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/transport/s2a.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/transport/transport.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/oauth2adapt/CHANGES.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/oauth2adapt/oauth2adapt.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/threelegged.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/CHANGES.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/arrow.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/bigquery.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/copy.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/dataset.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/doc.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/external.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/extract.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/inserter.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/internal/version.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/iterator.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/job.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/load.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/model.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/options.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/params.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/query.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/routine.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/auxiliary.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/auxiliary_go123.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/big_query_read_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/big_query_write_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/doc.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/helpers.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/annotations.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/arrow.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/avro.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/protobuf.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/storage.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/stream.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/table.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage_iterator.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/table.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/value.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/civil/civil.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/CHANGES.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/log.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/metadata.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/retry_linux.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/syscheck.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/syscheck_linux.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/syscheck_windows.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/iam/CHANGES.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/iam/apiv1/iampb/iam_policy.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/iam/apiv1/iampb/options.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/iam/apiv1/iampb/policy.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/iam/apiv1/iampb/resource_policy_member.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/internal/.repo-metadata-full.jsonis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/internal/detect/detect.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/internal/trace/trace.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/internal/uid/uid.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/alert_policy_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/auxiliary.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/auxiliary_go123.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/doc.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/gapic_metadata.jsonis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/group_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/helpers.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/metric_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/alert.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/alert_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/common.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/dropped_labels.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/group.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/group_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/metric.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/metric_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/mutation_record.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/notification.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/notification_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/query_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/service_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/snooze.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/snooze_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/span_context.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/uptime.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/uptime_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/notification_channel_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/query_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/service_monitoring_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/snooze_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/uptime_check_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/version.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/internal/version.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/CHANGES.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/TESTING.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/acl.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/bucket.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/client.gois excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (14)
cmd/sippy/migrate.gogo.modpkg/db/db.gopkg/db/migrate/migrate.gopkg/db/migrations/000001_create_test_analysis_by_job_by_dates.down.sqlpkg/db/migrations/000001_create_test_analysis_by_job_by_dates.up.sqlpkg/db/migrations/migrations.gopkg/db/partitionedtables.gotest/e2e/db/migrate/migrate_test.gotest/e2e/db/migrate/testmigrations/000001_create_e2e_test_table.down.sqltest/e2e/db/migrate/testmigrations/000001_create_e2e_test_table.up.sqltest/e2e/db/migrate/testmigrations/000002_add_column_to_e2e_test_table.down.sqltest/e2e/db/migrate/testmigrations/000002_add_column_to_e2e_test_table.up.sqltest/e2e/db/migrate/testmigrations/embed.go
💤 Files with no reviewable changes (1)
- pkg/db/partitionedtables.go
✅ Files skipped from review due to trivial changes (5)
- test/e2e/db/migrate/testmigrations/000002_add_column_to_e2e_test_table.down.sql
- test/e2e/db/migrate/testmigrations/000002_add_column_to_e2e_test_table.up.sql
- test/e2e/db/migrate/testmigrations/000001_create_e2e_test_table.down.sql
- test/e2e/db/migrate/testmigrations/000001_create_e2e_test_table.up.sql
- pkg/db/migrations/000001_create_test_analysis_by_job_by_dates.down.sql
🚧 Files skipped from review as they are similar to previous changes (3)
- pkg/db/migrations/migrations.go
- pkg/db/db.go
- pkg/db/migrations/000001_create_test_analysis_by_job_by_dates.up.sql
Contributor
Author
|
/test e2e |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 66: Update the vulnerable module versions in go.mod: bump
github.com/buger/jsonparser from v1.1.1 to at least v1.1.2 and bump the JWT
module (github.com/golang-jwt/jwt/v5) from v5.2.1 to at least v5.2.2; then run
the appropriate Go module commands (e.g., go get
github.com/buger/jsonparser@v1.1.2 and go get
github.com/golang-jwt/jwt/v5@v5.2.2, followed by go mod tidy) to update go.sum
and ensure builds pass.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: b76c37bb-51c7-4c61-8917-e1b3a4e1d8f7
⛔ Files ignored due to path filters (98)
go.sumis excluded by!**/*.sum,!go.sumvendor/cel.dev/expr/BUILD.bazelis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/MODULE.bazelis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/checked.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cel.dev/expr/eval.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cel.dev/expr/explain.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cel.dev/expr/syntax.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cel.dev/expr/value.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/CHANGES.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/metadata.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/retry.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/internal/byteutil/byteutil.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/ocb/ocb.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/armor/armor.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/armor/encode.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/canonical_text.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/ecdh/ecdh.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/ed25519/ed25519.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/ed448/ed448.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/errors/errors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/internal/algorithm/cipher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/internal/ecc/curve_info.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/internal/ecc/ed25519.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/internal/ecc/ed448.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/key_generation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/keys.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/aead_crypter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/aead_encrypted.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/compressed.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/config.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/config_v5.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/encrypted_key.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/literal.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/marker.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/one_pass_signature.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/opaque.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/packet.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/packet_sequence.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/packet_unsupported.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/padding.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/private_key.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/public_key.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/reader.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/recipient.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/signature.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/symmetric_key_encrypted.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/symmetrically_encrypted.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/symmetrically_encrypted_aead.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/symmetrically_encrypted_mdc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/userattribute.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/userid.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/read.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/s2k/s2k.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/s2k/s2k_cache.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/s2k/s2k_config.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/write.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/x25519/x25519.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/x448/x448.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/application_exception.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/binary_protocol.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/compact_protocol.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/configuration.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/debug_protocol.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/duplicate_protocol.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/exception.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/framed_transport.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/header_protocol.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/header_transport.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/json_protocol.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/logger.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/multiplexed_protocol.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/pointerize.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/pool.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/processor_factory.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/protocol.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/server_socket.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/simple_json_protocol.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/simple_server.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/slog.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/socket.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/socket_aix_syscall.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/socket_conn.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/socket_non_aix_syscall.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/socket_non_unix_conn.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/socket_unix_conn.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/ssl_server_socket.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/type.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/uuid.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/zlib_pool.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/zlib_transport.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cloudflare/circl/dh/x25519/curve_amd64.sis excluded by!vendor/**,!**/vendor/**vendor/github.com/cloudflare/circl/dh/x448/curve_amd64.sis excluded by!vendor/**,!**/vendor/**vendor/github.com/cloudflare/circl/ecc/goldilocks/curve.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cloudflare/circl/internal/conv/conv.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cloudflare/circl/internal/sha3/xor_unaligned.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cloudflare/circl/math/fp25519/fp_amd64.sis excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (2)
cmd/sippy/migrate.gogo.mod
🚧 Files skipped from review as they are similar to previous changes (1)
- cmd/sippy/migrate.go
# Conflicts: # go.mod
Contributor
Author
|
/test lint |
Contributor
|
Scheduling required tests: |
Contributor
Author
|
@coderabbitai review the current state of the pr and resolve all of your comments that have been addressed |
Contributor
🧩 Analysis chainLet me check the current state of my review comments on this PR. 🏁 Script executed: Length of output: 118425 Let me fetch the inline review comments to check their resolution status. 🏁 Script executed: Length of output: 3 Let me check the current state of the key files to assess what has been addressed. 🏁 Script executed: Length of output: 5980
All inline review comments are already cleared. Here's the status of each previously raised issue:
The two remaining nitpicks are low-value and the overall implementation looks solid. I'll kick off a fresh review of the current state now. ✅ Actions performedFull review triggered. |
Contributor
Author
|
/hold |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 86: The project uses andygrunwald/go-jira v1.14.0 which pulls in
github.com/golang-jwt/jwt v3.2.1 (vulnerable); update the go.mod dependency for
andygrunwald/go-jira to v1.17.0 or later so it transitively depends on
golang-jwt/jwt/v4 (e.g., v4.5.2). Run `go get
github.com/andygrunwald/go-jira@v1.17.0` (or higher), then `go mod tidy` and run
your tests/build to ensure no import breakages; confirm the go.sum now
references golang-jwt/jwt/v4 instead of the v3 entry.
In `@pkg/db/migrate/migrate.go`:
- Around line 148-156: Add input validation to prevent accidental direction
inversion by rejecting non-positive step counts: in MigrateDownWithFS check if
steps <= 0 at the top and return a descriptive error (e.g., "steps must be
positive"); ensure MigrateDown either performs the same validation or simply
relies on MigrateDownWithFS so callers cannot pass zero or negative values that
would flip to an UP migration. Reference the functions MigrateDownWithFS and
MigrateDown and return early on invalid input.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 6c475597-0197-4d94-a56f-f65a5462c192
⛔ Files ignored due to path filters (286)
go.sumis excluded by!**/*.sum,!go.sumvendor/cel.dev/expr/.bazelversionis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/.gitattributesis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/BUILD.bazelis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/CODE_OF_CONDUCT.mdis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/CONTRIBUTING.mdis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/GOVERNANCE.mdis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/MAINTAINERS.mdis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/MODULE.bazelis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/README.mdis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/WORKSPACEis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/WORKSPACE.bzlmodis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/checked.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cel.dev/expr/cloudbuild.yamlis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/eval.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cel.dev/expr/explain.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cel.dev/expr/regen_go_proto.shis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/regen_go_proto_canonical_protos.shis excluded by!vendor/**,!**/vendor/**vendor/cel.dev/expr/syntax.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cel.dev/expr/value.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/CHANGES.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/README.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/auth.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/compute.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/detect.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/filetypes.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/externalaccount/aws_provider.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/externalaccount/externalaccount.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/externalaccount/url_provider.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/externalaccount/x509_provider.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/externalaccountuser/externalaccountuser.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/gdch/gdch.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/impersonate/idtoken.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/impersonate/impersonate.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/internal/stsexchange/sts_exchange.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/credentials/selfsignedjwt.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/grpctransport/directpath.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/grpctransport/grpctransport.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/httptransport/httptransport.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/httptransport/trace.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/httptransport/transport.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/compute/compute.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/compute/manufacturer.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/compute/manufacturer_linux.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/compute/manufacturer_windows.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/credsfile/filetype.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/internal.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/jwt/jwt.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/transport/cba.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/transport/cert/enterprise_cert.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/transport/cert/secureconnect_cert.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/transport/cert/workload_cert.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/transport/s2a.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/internal/transport/transport.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/oauth2adapt/CHANGES.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/oauth2adapt/oauth2adapt.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/auth/threelegged.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/CHANGES.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/arrow.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/bigquery.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/copy.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/dataset.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/doc.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/external.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/extract.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/inserter.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/internal/version.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/iterator.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/job.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/load.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/model.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/options.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/params.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/query.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/routine.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/auxiliary.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/auxiliary_go123.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/big_query_read_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/big_query_write_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/doc.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/helpers.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/annotations.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/arrow.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/avro.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/protobuf.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/storage.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/stream.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage/apiv1/storagepb/table.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/storage_iterator.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/table.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/bigquery/value.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/civil/civil.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/CHANGES.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/log.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/metadata.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/retry.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/retry_linux.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/syscheck.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/syscheck_linux.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/compute/metadata/syscheck_windows.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/iam/CHANGES.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/iam/apiv1/iampb/iam_policy.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/iam/apiv1/iampb/options.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/iam/apiv1/iampb/policy.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/iam/apiv1/iampb/resource_policy_member.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/internal/.repo-metadata-full.jsonis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/internal/detect/detect.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/internal/trace/trace.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/internal/uid/uid.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/alert_policy_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/auxiliary.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/auxiliary_go123.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/doc.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/gapic_metadata.jsonis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/group_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/helpers.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/metric_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/alert.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/alert_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/common.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/dropped_labels.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/group.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/group_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/metric.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/metric_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/mutation_record.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/notification.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/notification_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/query_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/service_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/snooze.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/snooze_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/span_context.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/uptime.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/uptime_service.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/notification_channel_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/query_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/service_monitoring_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/snooze_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/uptime_check_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/apiv3/v2/version.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/monitoring/internal/version.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/CHANGES.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/TESTING.mdis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/acl.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/bucket.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/doc.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/dynamic_delay.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/emulator_test.shis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/experimental/experimental.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/grpc_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/grpc_dp.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/grpc_metrics.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/grpc_reader.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/grpc_reader_multi_range.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/grpc_writer.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/hmac.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/http_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/iam.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/internal/apiv2/auxiliary.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/internal/apiv2/auxiliary_go123.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/internal/apiv2/doc.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/internal/apiv2/gapic_metadata.jsonis excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/internal/apiv2/helpers.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/internal/apiv2/storage_client.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/internal/apiv2/storagepb/storage.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/internal/experimental.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/internal/version.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/invoke.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/notifications.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/option.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/reader.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/storage.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/trace.gois excluded by!vendor/**,!**/vendor/**vendor/cloud.google.com/go/storage/writer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp/app_engine.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp/bms.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp/detector.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp/faas.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp/gce.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp/gke.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/cloudmonitoring.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/constants.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/error.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/metric.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/option.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric/version.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping/resourcemapping.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/internal/byteutil/byteutil.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/ocb/ocb.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/armor/armor.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/armor/encode.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/canonical_text.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/ecdh/ecdh.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/ed25519/ed25519.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/ed448/ed448.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/errors/errors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/internal/algorithm/cipher.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/internal/ecc/curve_info.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/internal/ecc/ed25519.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/internal/ecc/ed448.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/key_generation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/keys.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/aead_crypter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/aead_encrypted.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/compressed.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/config.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/config_v5.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/encrypted_key.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/literal.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/marker.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/one_pass_signature.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/opaque.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/packet.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/packet_sequence.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/packet_unsupported.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/padding.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/private_key.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/public_key.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/reader.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/recipient.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/signature.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/symmetric_key_encrypted.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/symmetrically_encrypted.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/symmetrically_encrypted_aead.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/symmetrically_encrypted_mdc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/userattribute.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/packet/userid.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/read.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/read_write_test_data.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/s2k/s2k.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/s2k/s2k_cache.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/s2k/s2k_config.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/write.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/x25519/x25519.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/ProtonMail/go-crypto/openpgp/x448/x448.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/application_exception.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/binary_protocol.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/compact_protocol.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/configuration.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/debug_protocol.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/duplicate_protocol.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/exception.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/framed_transport.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/header_protocol.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/header_transport.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/json_protocol.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/logger.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/multiplexed_protocol.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/pointerize.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/pool.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/processor_factory.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/protocol.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/server_socket.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/simple_json_protocol.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/simple_server.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/slog.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/socket.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/socket_aix_syscall.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/socket_conn.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/socket_non_aix_syscall.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/socket_non_unix_conn.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/socket_unix_conn.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/ssl_server_socket.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/type.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/uuid.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/zlib_pool.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/apache/thrift/lib/go/thrift/zlib_transport.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/buger/jsonparser/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/buger/jsonparser/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/buger/jsonparser/bytes.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/buger/jsonparser/parser.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cloudflare/circl/dh/x25519/curve_amd64.sis excluded by!vendor/**,!**/vendor/**vendor/github.com/cloudflare/circl/dh/x448/curve_amd64.sis excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (14)
cmd/sippy/migrate.gogo.modpkg/db/db.gopkg/db/migrate/migrate.gopkg/db/migrations/000001_create_test_analysis_by_job_by_dates.down.sqlpkg/db/migrations/000001_create_test_analysis_by_job_by_dates.up.sqlpkg/db/migrations/migrations.gopkg/db/partitionedtables.gotest/e2e/db/migrate/migrate_test.gotest/e2e/db/migrate/testmigrations/000001_create_e2e_test_table.down.sqltest/e2e/db/migrate/testmigrations/000001_create_e2e_test_table.up.sqltest/e2e/db/migrate/testmigrations/000002_add_column_to_e2e_test_table.down.sqltest/e2e/db/migrate/testmigrations/000002_add_column_to_e2e_test_table.up.sqltest/e2e/db/migrate/testmigrations/embed.go
💤 Files with no reviewable changes (1)
- pkg/db/partitionedtables.go
| github.com/go-logr/logr v1.4.3 // indirect | ||
| github.com/go-logr/stdr v1.2.2 // indirect | ||
| github.com/goccy/go-json v0.10.3 // indirect | ||
| github.com/golang-jwt/jwt v3.2.1+incompatible // indirect |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Find which dependencies require jwt v3
echo "=== Dependencies requiring jwt v3 ==="
go mod graph | grep 'github.com/golang-jwt/jwt@v3' | head -20
echo ""
echo "=== Checking if we can exclude v3 ==="
rg -n 'github.com/golang-jwt/jwt[^/]' go.modRepository: openshift/sippy
Length of output: 357
🏁 Script executed:
# Read the go.mod file to see context around line 86-87
cat -n go.mod | sed -n '80,95p'Repository: openshift/sippy
Length of output: 1053
🌐 Web query:
GHSA-mh63-6h87-95cp jwt vulnerability
💡 Result:
GHSA-mh63-6h87-95cp is a high-severity vulnerability (CVSS 7.5-8.7) in the golang-jwt/jwt Go package, also known as CVE-2025-30204 and GO-2025-3553. It affects versions: v5 from 5.0.0-rc.1 before 5.2.2; v4 before 4.5.2; v3 from 3.2.0 before 3.2.3[1][2][3][4]. The issue is in parse.ParseUnverified, which uses strings.Split on untrusted input (JWT header) split by periods, leading to excessive memory allocation (O(n) bytes, constant factor ~16) on malicious Authorization: Bearer....... headers with many periods. This causes denial-of-service via resource exhaustion (CWE-405)[1][5][4]. Fixed in golang-jwt/jwt v5.2.2, v4.5.2, v3.2.3 via commits like bf316c4 and 0951d18[1][2]. Published March 21, 2025; last updated April 2025[1][4].
Citations:
- 1: GHSA-mh63-6h87-95cp
- 2: https://osv.dev/vulnerability/GHSA-mh63-6h87-95cp
- 3: https://pkg.go.dev/vuln/GO-2025-3553
- 4: https://nvd.nist.gov/vuln/detail/CVE-2025-30204
- 5: https://cve.circl.lu/vuln/ghsa-mh63-6h87-95cp
🏁 Script executed:
# Check available versions of go-jira and their dependencies
# First, let's see if we can find info about go-jira versions that don't depend on v3
rg -A 5 'andygrunwald/go-jira' go.modRepository: openshift/sippy
Length of output: 327
🏁 Script executed:
# Search for information about go-jira versions
# Since we can't directly query Go registries, let's check if there are any comments or documentation in the repo
rg -i 'go-jira|jira' go.mod | head -20Repository: openshift/sippy
Length of output: 100
🌐 Web query:
go-jira andygrunwald latest version jwt dependency
💡 Result:
The latest version of github.com/andygrunwald/go-jira (maintained by Andy Grunwald) is v1.17.0, released on 2025-09-16.[1][2][3][4][5] In this version, it depends on github.com/golang-jwt/jwt/v4 v4.5.2.[5][6] This was upgraded from v4.4.2 in v1.16.1 to address CVE-2025-30204.[2][5]
Citations:
- 1: https://pkg.go.dev/github.com/andygrunwald/go-jira@v1.17.0
- 2: https://github.com/andygrunwald/go-jira/releases
- 3: https://pkg.go.dev/github.com/andygrunwald/go-jira
- 4: https://github.com/andygrunwald/go-jira
- 5: https://github.com/andygrunwald/go-jira/releases/tag/v1.17.0
- 6: andygrunwald/go-jira@v1.16.1...v1.17.0
Upgrade andygrunwald/go-jira to resolve vulnerable JWT v3 dependency.
The github.com/golang-jwt/jwt v3.2.1+incompatible has a HIGH severity vulnerability (GHSA-mh63-6h87-95cp / CVE-2025-30204) allowing excessive memory allocation during header parsing. This is brought in by andygrunwald/go-jira v1.14.0. Upgrade go-jira to v1.17.0 or later, which now depends on golang-jwt/jwt/v4 v4.5.2 (patched).
🧰 Tools
🪛 OSV Scanner (2.3.8)
[HIGH] 86-86: github.com/golang-jwt/jwt 3.2.1+incompatible: Excessive memory allocation during header parsing in github.com/golang-jwt/jwt
(GO-2025-3553)
[HIGH] 86-86: github.com/golang-jwt/jwt 3.2.1+incompatible: jwt-go allows excessive memory allocation during header parsing
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 86, The project uses andygrunwald/go-jira v1.14.0 which pulls
in github.com/golang-jwt/jwt v3.2.1 (vulnerable); update the go.mod dependency
for andygrunwald/go-jira to v1.17.0 or later so it transitively depends on
golang-jwt/jwt/v4 (e.g., v4.5.2). Run `go get
github.com/andygrunwald/go-jira@v1.17.0` (or higher), then `go mod tidy` and run
your tests/build to ensure no import breakages; confirm the go.sum now
references golang-jwt/jwt/v4 instead of the v3 entry.
Comment on lines
+148
to
+156
| func MigrateDownWithFS(gormDB *gorm.DB, fsys fs.FS, migrationsTable string, steps int) error { | ||
| m, cleanup, err := NewMigrateWithFS(gormDB, fsys, migrationsTable) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| defer func() { _ = cleanup() }() | ||
| if err := m.Steps(-steps); err != nil { | ||
| return fmt.Errorf("migrate down failed: %w", err) | ||
| } |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
In github.com/golang-migrate/migrate/v4, what is the exact direction behavior of Migrate.Steps(n) for positive vs negative n?
💡 Result:
In github.com/golang-migrate/migrate/v4, the Migrate.Steps(n) method migrates up (applies the next n up migrations from the current version) if n is positive, and migrates down (applies the previous |n| down migrations from the current version) if n is negative. If n == 0, it returns ErrNoChange without doing anything.[1]
Citations:
🏁 Script executed:
# Find all calls to MigrateDownWithFS in the codebase
rg "MigrateDownWithFS" --type go -B 2 -A 2Repository: openshift/sippy
Length of output: 1768
🏁 Script executed:
# Check for similar validation patterns in migrate.go or related files
rg "steps.*<|>|<=|>=" pkg/db/migrate/ --type go -B 1 -A 1Repository: openshift/sippy
Length of output: 41
🏁 Script executed:
# Look for any integration tests or usages in cmd/
fd -e go . cmd/ | xargs rg "MigrateDownWithFS" -l 2>/dev/null || echo "No matches in cmd/"Repository: openshift/sippy
Length of output: 78
Validate rollback step count before negating it.
Line 154 passes -steps to m.Steps(...). If steps is zero or negative, this inverts the migration direction: MigrateDownWithFS(..., -2) would migrate UP instead of rolling back. Add input validation to reject non-positive steps.
- Proposed fix: Check
if steps <= 0at function entry and return error. - Also affects
MigrateDown(line 160), which wraps this function without validation.
Proposed fix
func MigrateDownWithFS(gormDB *gorm.DB, fsys fs.FS, migrationsTable string, steps int) error {
+ if steps <= 0 {
+ return fmt.Errorf("steps must be greater than 0")
+ }
+
m, cleanup, err := NewMigrateWithFS(gormDB, fsys, migrationsTable)
if err != nil {
return err
}
defer func() { _ = cleanup() }()
if err := m.Steps(-steps); err != nil {
return fmt.Errorf("migrate down failed: %w", err)
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| func MigrateDownWithFS(gormDB *gorm.DB, fsys fs.FS, migrationsTable string, steps int) error { | |
| m, cleanup, err := NewMigrateWithFS(gormDB, fsys, migrationsTable) | |
| if err != nil { | |
| return err | |
| } | |
| defer func() { _ = cleanup() }() | |
| if err := m.Steps(-steps); err != nil { | |
| return fmt.Errorf("migrate down failed: %w", err) | |
| } | |
| func MigrateDownWithFS(gormDB *gorm.DB, fsys fs.FS, migrationsTable string, steps int) error { | |
| if steps <= 0 { | |
| return fmt.Errorf("steps must be greater than 0") | |
| } | |
| m, cleanup, err := NewMigrateWithFS(gormDB, fsys, migrationsTable) | |
| if err != nil { | |
| return err | |
| } | |
| defer func() { _ = cleanup() }() | |
| if err := m.Steps(-steps); err != nil { | |
| return fmt.Errorf("migrate down failed: %w", err) | |
| } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pkg/db/migrate/migrate.go` around lines 148 - 156, Add input validation to
prevent accidental direction inversion by rejecting non-positive step counts: in
MigrateDownWithFS check if steps <= 0 at the top and return a descriptive error
(e.g., "steps must be positive"); ensure MigrateDown either performs the same
validation or simply relies on MigrateDownWithFS so callers cannot pass zero or
negative values that would flip to an UP migration. Reference the functions
MigrateDownWithFS and MigrateDown and return early on invalid input.
Contributor
|
@neisw: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding schema management for
test_analysis_by_job_by_dateswhich previously was unmanaged.Summary by CodeRabbit
New Features
Tests
Chores