Skip to content

ROSAENG-1083: remove unrelated jobs from 4.22 section#3528

Open
bmeng wants to merge 1 commit into
openshift:mainfrom
bmeng:stable-ch
Open

ROSAENG-1083: remove unrelated jobs from 4.22 section#3528
bmeng wants to merge 1 commit into
openshift:mainfrom
bmeng:stable-ch

Conversation

@bmeng
Copy link
Copy Markdown
Contributor

@bmeng bmeng commented May 13, 2026

Remove jobs from the 4.22 section which are not belonging

All the existing rosa-e2e jobs should be handled in rosa-stage section now

Summary by CodeRabbit

  • Chores
    • Updated CI test configurations: removed outdated e2e test entries and added new load generator test configurations for 50, 100, and 1000 worker counts.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 13, 2026

@bmeng: This pull request references ROSAENG-1083 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Remove jobs from the 4.22 section which are not belonging

All the existing rosa-e2e jobs should be handled in rosa-stage section now

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 13, 2026
@openshift-ci openshift-ci Bot requested review from neisw and smg247 May 13, 2026 07:15
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 14bcfe06-92e1-47c2-9ec6-df9af35ca22c

📥 Commits

Reviewing files that changed from the base of the PR and between 75f85c7 and 05ace06.

📒 Files selected for processing (1)
  • config/openshift.yaml
💤 Files with no reviewable changes (1)
  • config/openshift.yaml

Walkthrough

Configuration update in config/openshift.yaml removes a block of periodic CI enablement flags for ROSA integration tests and adds three new periodic CI flags for OLS load generator tests with 50, 100, and 1000 worker configurations.

Changes

Periodic CI Flags Update

Layer / File(s) Summary
OLS load generator CI flags
config/openshift.yaml
Replaces deprecated ROSA periodic CI flags with three new OLS load generator test flags for 50workers, 100workers, and 1000workers configurations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing unrelated jobs from the 4.22 section of the configuration file, which aligns with the changeset that removes ROSA-related CI enablement flags.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo tests found in PR. All test files use standard Go testing package and testify assertions, not Ginkgo framework. Check is not applicable.
Test Structure And Quality ✅ Passed Custom check requires reviewing Ginkgo test code for quality requirements. This PR only modifies config/openshift.yaml (YAML CI/CD configuration), not test code. Check is not applicable.
Microshift Test Compatibility ✅ Passed PR only modifies CI configuration (config/openshift.yaml) with no new Ginkgo e2e tests added. The MicroShift Test Compatibility check is not applicable to pure configuration changes.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Custom check not applicable. PR contains only YAML configuration changes in config/openshift.yaml with no new Ginkgo e2e tests added. SNO compatibility check is only relevant for new test code.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI job configuration metadata in config/openshift.yaml, not deployment manifests or controllers. The topology-aware scheduling check does not apply to configuration files.
Ote Binary Stdout Contract ✅ Passed PR only modifies config/openshift.yaml. OTE Binary Stdout Contract check applies to process-level code only. No code changes present.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds configuration and standard Go tests using testing.T, not Ginkgo e2e tests. Custom check applies only to new Ginkgo tests (It(), Describe(), etc.). Not applicable here.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@dustman9000
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2026
@stbenjam
Copy link
Copy Markdown
Member

This particular file is generated, I think the ci-tools sippy-config-generator will just add them back

@stbenjam
Copy link
Copy Markdown
Member

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5edf590 and 2 for PR HEAD 05ace06 in total

@stbenjam
Copy link
Copy Markdown
Member

/test yaml-lint

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

@bmeng: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/yaml-lint 05ace06 link true /test yaml-lint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@deepsm007
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, deepsm007, dustman9000, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants