Skip to content

fix: restore pre-commit hook wording in gitleaks.toml#454

Open
anispate wants to merge 1 commit into
openshift:masterfrom
anispate:fix-gitleaks-precommit-wording
Open

fix: restore pre-commit hook wording in gitleaks.toml#454
anispate wants to merge 1 commit into
openshift:masterfrom
anispate:fix-gitleaks-precommit-wording

Conversation

@anispate

@anispate anispate commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes a comment wording in .gitleaks.toml that was incorrectly changed in #447.

Before (merged in #447):

# Integration: Runs via prek and Tekton CI

After:

# Integration: Runs in pre-commit hook (via prek) and Tekton CI

"pre-commit hook" is standard git terminology describing the hook type (the git hook that fires before each commit) — it is not a reference to the pre-commit Python tool. The change in #447 was an over-correction; this restores the accurate description while keeping the explicit prek tool reference.

The usage command (prek run gitleaks) from #447 is correct and unchanged.

Flagged by @boranx in PR review.

"pre-commit hook" is a valid generic term for the git hook type —
it describes the mechanism (runs before each commit), not the
pre-commit Python tool. The previous change incorrectly replaced it
with "prek" alone; restore the original intent while keeping the
prek tool reference explicit.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci openshift-ci Bot requested review from aliceh and nephomaniac July 6, 2026 19:01
@openshift-ci

openshift-ci Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anispate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2026
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@anispate, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 8 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ecb7f767-a65d-4167-9790-6c38a96b16af

📥 Commits

Reviewing files that changed from the base of the PR and between 6773aa8 and 14ecc3b.

📒 Files selected for processing (1)
  • .gitleaks.toml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@anispate: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.44%. Comparing base (6773aa8) to head (14ecc3b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #454   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          11       11           
  Lines         704      704           
=======================================
  Hits          510      510           
  Misses        173      173           
  Partials       21       21           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants