Update check-role-prefix script#3903
Merged
Valkyrie00 merged 1 commit intoopenstack-k8s-operators:mainfrom May 8, 2026
Merged
Conversation
Now the script can handle a PR containing more than one commit where each commit might update or not roles. Now instead of checking last commit, it checks the whole commits modified and iterates over them. Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
force-pushed
the
check-role-prefix-multiple-commits-one-role-per-commit
branch
from
27995c6 to
2fd43b8
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
michburk
approved these changes
May 6, 2026
Contributor
michburk
left a comment
michburk
left a comment
There was a problem hiding this comment.
podified-multinode-edpm-deployment-crc etc still running despite the changes to exclude them from running. Enrique is assuming that this will work properly once merged. We will see
/lgtm
Valkyrie00
approved these changes
May 8, 2026
Valkyrie00
merged commit cfcb453
into
openstack-k8s-operators:main
9 of 10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the script can handle a PR containing more than
one commit where each commit might update or not
roles.
Now instead of checking last commit, it checks the whole
commits modified and iterates over them.
Signed-off-by: Enrique Vallespi Gil evallesp@redhat.com
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com