List packagemanifests by CATALOG in scripts/gen-rhosls.sh - #59
Conversation
With the new release to the community-operators catalog (v0.0.2) the
"make kuttl-test-ocp" Makefile target is failing (and probably others).
The issue is that scripts/gen-rhosls.sh looks up the packagemanifest by
name (openstack-lightspeed-operator) only, without filtering by catalog.
Because the community-operators catalog also ships a packagemanifest
with that same name, the lookup is ambiguous and can return the
community CSV_VERSION (v0.0.2) instead of the version from the catalog
we build internally as part of "make kuttl-test-ocp".
This commit filters packagemanifests by the catalog label so that we
pick only the packagemanifest coming from the ${CATALOG} catalog.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe RHOSLS generation script now lists matching ChangesRHOSLS generation
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The script now limits packagemanifest selection to the intended catalog; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
CATALOG in scripts/gen-rhosls.sh
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lpiwowar, umago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@lpiwowar: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
With the new release to the community-operators catalog (v0.0.2) the "make kuttl-test-ocp" Makefile target is failing (and probably others).
The issue is that scripts/gen-rhosls.sh looks up the packagemanifest by name (openstack-lightspeed-operator) only, without filtering by catalog. Because the community-operators catalog also ships a packagemanifest with that same name, the lookup is ambiguous and can return the community CSV_VERSION (v0.0.2) instead of the version from the catalog we build internally as part of "make kuttl-test-ocp".
This commit filters packagemanifests by the catalog label so that we pick only the packagemanifest coming from the ${CATALOG} catalog.