Configure renderd request queue limits#498
Open
Komzpa wants to merge 2 commits intoopenstreetmap:masterfrom
Open
Configure renderd request queue limits#498Komzpa wants to merge 2 commits intoopenstreetmap:masterfrom
Komzpa wants to merge 2 commits intoopenstreetmap:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This replaces the old hard-coded dirty queue limit approach from #152 with configurable
renderd.confqueue limits.request_queue_limitanddirty_queue_limitoptions to the[renderd]sectionContext
The old PR tried to make the dirty queue much larger globally. The review thread pointed out that this is deployment-specific, can make stale background work accumulate, and does not solve queue fairness. This version keeps the default behavior unchanged and lets operators opt into larger queues with rollout guidance.
Testing
cmake --build build --target gen_tile_test render_list renderd_config_test renderd_config_test_helper -j2 ctest --test-dir build -R '^(gen_tile_test|renderd_config_test)$' --output-on-failureBoth targeted tests pass locally.