Repository navigation
fix(authz): reuse policy and entity resolution within bulk requests - #3990
Draft
strantalis wants to merge 1 commit into
Draft
strantalis wants to merge 1 commit into
strantalis wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Contributor
Contributor
|
I think this approach generally makes sense, but I think it's lower priority than some of the optimizations in the other layers of the stack. |
strantalis
force-pushed
the
codex/authz-perf/bulk-reuse
branch
from
October 1, 2026 16:06
371ca30 to
4db2582
Compare
Contributor
X-Test Failure Report |
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Contributor
strantalis
force-pushed
the
codex/authz-perf/bulk-reuse
branch
from
October 1, 2026 21:03
4db2582 to
79b3d7c
Compare
Contributor
X-Test Failure Report |
strantalis
removed this pull request from stack #3992
October 1, 2026 21:07
strantalis
added this pull request to stack #4131
October 1, 2026 21:07
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Contributor
strantalis
force-pushed
the
codex/authz-perf/bulk-reuse
branch
from
October 1, 2026 22:10
79b3d7c to
e3ce12d
Compare
Contributor
X-Test Failure Report |
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Contributor
jakedoublev
force-pushed
the
codex/authz-perf/bulk-reuse
branch
from
October 2, 2026 19:45
e3ce12d to
ed5fef8
Compare
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Contributor
strantalis
force-pushed
the
codex/authz-perf/bulk-reuse
branch
from
October 4, 2026 22:47
ed5fef8 to
d35dcca
Compare
Contributor
X-Test Failure Report |
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Contributor
strantalis
force-pushed
the
codex/authz-perf/bulk-reuse
branch
from
October 5, 2026 17:08
d35dcca to
7e6cf6a
Compare
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Contributor
Signed-off-by: strantalis <strantalis@virtru.com>
strantalis
force-pushed
the
codex/authz-perf/bulk-reuse
branch
from
October 6, 2026 20:08
7e6cf6a to
ef264fc
Compare
Contributor
X-Test Failure Report |
Contributor
Benchmark results, click to expandBulk Benchmark Results
TDF3 Benchmark Results
|
Contributor
Benchmark results, click to expandBulk Benchmark Results
TDF3 Benchmark Results
|
Contributor
|
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated entries in
GetDecisionBulkfetch the same policy and resolve the same entity again. Reuse successful results within a sequential bulk RPC, bounded at eight policy sets and 32 entity resolutions.Keys include normalized FQNs, the complete entity/token request, resource context, and environment-entity mode. Each RPC gets fresh tables; errors are not cached. This helps repeated bulk entries and does not reuse results across independent requests in the scale test.
Layer 3 of 4, based on #3989 and rebased on
mainatf992b60d.Rebase verification (2026-10-05): all remaining patches are unchanged and based on
mainwith #3987 merged. Authorization race tests, SDK README tests, formatting, and lint for the stack diff passed. Prior full repository check limitations are recorded in #3991.