Skip to content

fix(ci): configure additional KAS cache as nanoseconds #4067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
c-r33d merged 1 commit into from
Sep 17, 2026
+9 −2
Merged

fix(ci): configure additional KAS cache as nanoseconds #4067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions test/start-additional-kas/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ inputs:
required: false
key-cache-expiration:
default: ''
description: 'Private-key cache expiration as a Go duration (e.g. 5m); 0 disables caching; empty inherits the platform configuration'
description: 'Private-key cache expiration in nanoseconds (e.g. 300000000000 for 5 minutes); 0 disables caching; empty inherits the platform configuration'
required: false
root-key:
default: ''
Expand Down Expand Up @@ -68,6 +68,7 @@ runs:
PQC_ENABLED: ${{ inputs.pqc-enabled }}
KEY_MANAGEMENT: ${{ inputs.key-management }}
KAS_URI_FROM_KAO: ${{ inputs.kas-uri-from-kao }}
KEY_CACHE_EXPIRATION: ${{ inputs.key-cache-expiration }}
ROOT_KEY: ${{ inputs.root-key }}
LOG_LEVEL: ${{ inputs.log-level }}
LOG_TYPE: ${{ inputs.log-type }}
Expand Down Expand Up @@ -126,6 +127,12 @@ runs:
;;
esac

# KAS decodes time.Duration from an integer number of nanoseconds.
if [[ -n "${KEY_CACHE_EXPIRATION}" && ! "${KEY_CACHE_EXPIRATION}" =~ ^(0|[1-9][0-9]*)$ ]]; then
echo "Error: key-cache-expiration must be a nonnegative integer number of nanoseconds, or empty to inherit."
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
exit 1
fi

# Validate key-management and root-key combination
if [[ "${KEY_MANAGEMENT}" == "true" && -z "${ROOT_KEY}" ]]; then
echo "Error: root-key is required when key-management is true."
Expand Down Expand Up @@ -215,7 +222,7 @@ runs:
| (.services.kas.key_management = (env(KEY_MANAGEMENT) == "true"))
| (.services.kas.preview.key_management = (env(KEY_MANAGEMENT) == "true"))
| (.services.kas.kas_uri_from_kao = (env(KAS_URI_FROM_KAO) == "true"))
| with(select(strenv(KEY_CACHE_EXPIRATION) != ""); .services.kas.key_cache_expiration = strenv(KEY_CACHE_EXPIRATION))
| with(select(strenv(KEY_CACHE_EXPIRATION) != ""); .services.kas.key_cache_expiration = env(KEY_CACHE_EXPIRATION))
| (.services.kas.registered_kas_uri = "http://localhost:" + env(KAS_PORT))
| del(.services.kas.root_key)
| (.logger.level = env(LOG_LEVEL))
Expand Down
Loading