Repository navigation
fix(ci): build otdfctl release binaries with GOWORK=off [backport to release/otdfctl/v0.38] - #4117
Merged
elizabethhealy merged 1 commit intoSep 28, 2026
Conversation
4 tasks
## Summary `release-otdfctl.yaml` runs `make build` with the root `go.work`, so the published otdfctl binaries are compiled against the **in-repo** `sdk/`, `protocol/go`, `lib/*` instead of the versions pinned in `otdfctl/go.mod`. That's inconsistent with: - the release-please PR check, which runs `.github/scripts/work-init.sh` to drop `./sdk` from the workspace and validate against the pinned versions - what users get from `go install github.com/opentdf/platform/otdfctl@vX` On release branches this can break a release after it's published: e.g. on `release/otdfctl/v0.38`, otdfctl pins `sdk v0.33.0` (which includes #3945), but the in-tree `sdk/` did not until #4114. The release-please check would pass while the post-publish binary build would fail to compile, leaving a release with no artifacts. This sets `GOWORK=off` on the build step so binaries are built strictly from `otdfctl/go.mod`. `setup-go` still reads the Go version from `go.work`. ## Test plan - [ ] actionlint passes - [ ] Locally: `cd otdfctl && GOWORK=off make build` succeeds on `main` - [ ] Next `otdfctl/v*` release uploads binaries successfully - [ ] Consider backporting to active `release/otdfctl/*` branches <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated the release build to use dependencies specified for `otdfctl`. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: CoopAgent <coopagent@users.noreply.github.com> (cherry picked from commit e8a2f7f)
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
opentdf-automation
Bot
force-pushed
the
backport-4115-to-release/otdfctl/v0.38
branch
from
September 28, 2026 18:47
574146a to
d95b6ce
Compare
Contributor
X-Test Failure Report |
elizabethhealy
approved these changes
Sep 28, 2026
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Contributor
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #4115 to
release/otdfctl/v0.38.