Repository navigation
fix(authz): scope uncached direct decisions to resource policy - #4193
Merged
strantalis merged 3 commits intoOct 8, 2026
Merged
strantalis merged 3 commits into
strantalis merged 3 commits into
Conversation
strantalis
added this pull request to stack #4195
October 7, 2026 15:44
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Benchmark results, click to expandBulk Benchmark Results
TDF3 Benchmark Results
|
Contributor
strantalis
force-pushed
the
codex/authz-uncached/direct-decisions
branch
from
October 7, 2026 18:22
6c575d0 to
51bb875
Compare
strantalis
force-pushed
the
codex/authz-uncached/policy-read
branch
from
October 7, 2026 18:22
03a0eed to
3bd2edc
Compare
Contributor
X-Test Failure Report |
Contributor
Benchmark results, click to expandBulk Benchmark Results
TDF3 Benchmark Results
|
Contributor
Signed-off-by: strantalis <strantalis@virtru.com>
Signed-off-by: strantalis <strantalis@virtru.com>
Signed-off-by: strantalis <strantalis@virtru.com>
strantalis
force-pushed
the
codex/authz-uncached/direct-decisions
branch
from
October 7, 2026 19:21
51bb875 to
675bbfc
Compare
Contributor
X-Test Failure Report |
Contributor
Benchmark results, click to expandBulk Benchmark Results
TDF3 Benchmark Results
|
Contributor
Benchmark results, click to expandBulk Benchmark Results
TDF3 Benchmark Results
|
Contributor
|
Contributor
strantalis
removed this pull request from stack #4195
October 8, 2026 14:08
strantalis
merged commit Oct 8, 2026
675bbfc
into
codex/authz-uncached/policy-read
72 of 81 checks passed
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
With caching disabled, enabling direct entitlements currently loads every attribute and subject mapping before a decision. Fetch the policy referenced by the request's resources through the PDP policy read from #4192.
Cached decisions and entitlement enumeration retain their full-policy path. Registered resources and obligations still load during construction.
Testing Instructions
Authorization race tests and changed-code lint pass, covering attribute rules, missing/inactive values, action mismatch, and cache/enumeration behavior. The previous rebased stack's CI scale run completed all 800 direct requests with zero failures: at concurrency 50, median 233 ms and p95 289 ms. The baseline timed out all 200 requests at that concurrency. These are individual CI runs; the RPC simplification still needs a fresh scale measurement.