chore(xtest): flatten slashed branch names into dist/src tags by dmihalcik-virtru · Pull Request #620 · opentdf/tests

dmihalcik-virtru · 2026-09-23T17:16:58Z

Split out of #583.

A branch ref like feat/DSPX-2604-createtdf-chunked resolved by name (not by SHA) kept its slash in the tag, nesting dist/<tag>/ and src/<tag>/ one level deeper than every consumer expects: xtest's all_versions_of() lists dist/*/ and the Go Makefile finds src/*/, so the build was silently discovered as a bare "feat" directory with no cli.sh in it.

Flattens the tag the same way _classify_sha_match already flattens a branch reached by SHA.

Standalone fix, no dependency on the rest of the DSPX-4372 stack. First in the stack because the K-arm benchmark work's own tests exercise this.

Summary by CodeRabbit

Bug Fixes
- Branch names containing / now produce tags with -- in place of slashes during resolution, keeping the resulting tag format consistent across branch resolution paths.

A branch ref like 'feat/DSPX-2604-createtdf-chunked' resolved by name (not by SHA) kept its slash in the tag, nesting dist/<tag>/ and src/<tag>/ one level deeper than every consumer expects: xtest's all_versions_of() lists dist/*/ and the Go Makefile finds src/*/, so the build was silently discovered as a bare 'feat' directory with no cli.sh in it. Flatten the tag the same way _classify_sha_match already flattens a branch reached by SHA.

coderabbitai · 2026-09-23T17:17:05Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c96f5e84-daea-45cc-b5c1-4230db50ce0b

📥 Commits

Reviewing files that changed from the base of the PR and between 384b310 and 876925e.

📒 Files selected for processing (2)

otdf-sdk-mgr/src/otdf_sdk_mgr/resolve.py
otdf-sdk-mgr/tests/test_resolve.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

Explicit branch-name resolution now replaces slashes in the result tag with double hyphens. Tests verify the flattened tag and retained branch alias.

Changes

Branch Tag Flattening

Layer / File(s)	Summary
Flatten branch-name tags `otdf-sdk-mgr/src/otdf_sdk_mgr/resolve.py`, `otdf-sdk-mgr/tests/test_resolve.py`	Branch-name resolution replaces `/` with `--` in the result tag. Tests check the flattened tag and branch alias, and update assertions for a non-main branch.

Estimated code review effort: 2 (Simple) | ~8 minutes

Suggested reviewers: abarabash-virtru

Merge Risk: ⚪ Minimal · up to 87692

The branch-tag fix appears ready to merge after normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: flattening branch names that contain slashes into distribution and source tags.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Fix all pre-merge checks with AI

✨ Finishing Touches 💡 2

📝 Generate docstrings 💡

Commit to this branch
Create a new PR

🛠️ Fix failing CI checks 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{A rabbit checks each branch tag,
Slashes turn to double dashes.
The alias keeps its branch name,
Tests follow each changed path,
Then hop away through green fields.}

_{Comment @coderabbitai help to get the list of available commands.}

sonarqubecloud · 2026-09-23T17:17:35Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-09-23T17:40:26Z

X-Test Failure Report

server-logs-js@main-main
server-logs-js@main-v0.27.0
server-logs-go@v0.38.0-main
✅ java@main-main
server-logs-java@main-v0.27.0
server-logs-js@v0.4.0-main
server-logs-go@main-v0.27.0
✅ go@v0.38.0-v0.27.0
server-logs-go@main-main
server-logs-js@v0.4.0-v0.27.0
server-logs-java@v0.19.0-v0.27.0
server-logs-java@v0.19.0-main

github-actions · 2026-09-25T18:28:54Z

dmihalcik-virtru mentioned this pull request Sep 23, 2026

feat(xtest): compare up to four benchmark arms in one run #621

Closed

dmihalcik-virtru mentioned this pull request Sep 23, 2026

feat(xtest): benchmark two named refs via workflow_dispatch #583

Closed

dmihalcik-virtru changed the title ~~fix(otdf-sdk-mgr): flatten slashed branch names into dist/src tags~~ chore(xtest): flatten slashed branch names into dist/src tags Sep 23, 2026

dmihalcik-virtru marked this pull request as ready for review September 23, 2026 17:20

dmihalcik-virtru requested review from a team as code owners September 23, 2026 17:20

pflynn-virtru approved these changes Sep 28, 2026

View reviewed changes

elizabethhealy approved these changes Sep 28, 2026

View reviewed changes

dmihalcik-virtru merged commit 04ec8a0 into main Sep 28, 2026
30 of 42 checks passed

dmihalcik-virtru deleted the DSPX-4372-01-resolve-slash-flatten branch September 28, 2026 14:38

Navigation Menu

chore(xtest): flatten slashed branch names into dist/src tags - #620

chore(xtest): flatten slashed branch names into dist/src tags#620
dmihalcik-virtru merged 1 commit into
mainfrom
DSPX-4372-01-resolve-slash-flatten

dmihalcik-virtru commented Sep 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 23, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

sonarqubecloud Bot commented Sep 23, 2026

Uh oh!

github-actions Bot commented Sep 23, 2026

Uh oh!

github-actions Bot commented Sep 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dmihalcik-virtru commented Sep 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

sonarqubecloud Bot commented Sep 23, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented Sep 23, 2026

X-Test Failure Report

Uh oh!

github-actions Bot commented Sep 25, 2026

X-Test Results

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dmihalcik-virtru commented Sep 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 23, 2026 •

edited

Loading