feat(xtest): cross-SDK benchmark roll-up and decision-first summaries - #623
Draft
dmihalcik-virtru wants to merge 1 commit into
Draft
dmihalcik-virtru wants to merge 1 commit into
dmihalcik-virtru wants to merge 1 commit into
Conversation
Each SDK's bench job already reports its own verdict; nothing combined the three into one answer to 'did this change regress anything', and a reviewer had to open three job summaries to find out. - perf/report.py: the per-SDK summary is reordered for progressive disclosure -- TL;DR, compared builds, what changed, then the full table -- and the effect-at-a-glance scale is tail-compressed so a planted 3x outlier does not flatten every ordinary-sized effect into the same pixel. Renders bake-off results (from the K-arm core) alongside the gated verdicts. - perf/aggregate.py (new): pure-stdlib -- no dependency sync needed in a job that runs after everything else already finished -- cross-SDK roll-up read from the JSON artifacts, not the markdown, so a partially failed matrix still gets a combined answer for whichever SDKs reported. - xtest.yml: new benchmark-summary job downloads every SDK's bench-result-* artifact and publishes the roll-up as the step summary once all three matrix jobs finish. Renamed the per-SDK upload from the emoji-prefixed 'bench-<sdk>' to 'bench-result-<sdk>', which is what the roll-up's artifact-name pattern actually matches -- the emoji form was never discoverable by it. Built on the K-arm core (bake-off rendering) and payload sizes (the summary reads whatever payload set the run measured).
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #583. Stacked on #622.
Each SDK's bench job already reports its own verdict; nothing combined the three into one answer to "did this change regress anything," and a reviewer had to open three job summaries to find out.
perf/report.py: the per-SDK summary is reordered for progressive disclosure (TL;DR, compared builds, what changed, then the full table), and the effect-at-a-glance scale is tail-compressed so a planted outlier does not flatten every ordinary-sized effect. Renders bake-off results from the K-arm core alongside gated verdicts.perf/aggregate.py(new): pure-stdlib cross-SDK roll-up read from the JSON artifacts, not the markdown, so a partially failed matrix still gets a combined answer for whichever SDKs reported.xtest.yml: newbenchmark-summaryjob downloads every SDK'sbench-result-*artifact and publishes the roll-up as the step summary once all three matrix jobs finish. Renamed the per-SDK upload from the emoji-prefixedbench-<sdk>tobench-result-<sdk>, which is what the roll-up's artifact-name pattern actually matches.Built on #622 (payload sizes) and #621 (K-arm core, for bake-off rendering).