Prevent including private headers of nanovdb-editor - #693
Open
phapalova wants to merge 7 commits into
Open
Conversation
Signed-off-by: Petra Hapalova <phapalova@nvidia.com>
Signed-off-by: Petra Hapalova <phapalova@nvidia.com>
…include Signed-off-by: Petra Hapalova <phapalova@nvidia.com>
phapalova
marked this pull request as ready for review
July 17, 2026 14:00
phapalova
marked this pull request as draft
July 17, 2026 14:00
Signed-off-by: Petra Hapalova <phapalova@nvidia.com>
phapalova
marked this pull request as ready for review
July 20, 2026 11:01
Signed-off-by: Petra Hapalova <phapalova@nvidia.com>
harrism
reviewed
Jul 20, 2026
harrism
left a comment
harrism
left a comment
Contributor
There was a problem hiding this comment.
Could nanovdb-editor export an INTERFACE target for the public headers under PUBLIC_HEADERS_ONLY, so fVDB links nanovdb_editor::public_headers instead of hard-coding ${nanovdb_editor_BINARY_DIR}/include?
I think this would be the more cmake-idiomatic approach. This PR is reasonable, but I think it would be nicer as an interface library.
…include Signed-off-by: Petra Hapalova <phapalova@nvidia.com>
…stead of direct include paths Signed-off-by: Petra Hapalova <phapalova@nvidia.com>
phapalova
enabled auto-merge (squash)
July 22, 2026 13:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPM downloads the entire nanovdb-editor repository, but only the headers in the top-level nanovdb_editor folder (PNanoVDBExt.h and putil/) are the public, versioned interface that fVDB is allowed to include as <nanovdb_editor/...>. Everything else (editor/, compute/, raster/, vulkan/, imgui/, ...) is internal implementation detail.
In openvdb/nanovdb-editor#218 editor has added a build config to only copy the public headers. This PR adds this config and points the include directory to the build folder instead of to the CPM cache with the cloned repository.