Drop support for PyTorch < 2.6 - #700
Open
matthewdcong wants to merge 1 commit into
Open
Conversation
matthewdcong
force-pushed
the
drop_old_pytorch_support
branch
from
July 23, 2026 00:32
efe01ae to
de2f2a8
Compare
Signed-off-by: Matthew Cong <mcong@nvidia.com>
matthewdcong
force-pushed
the
drop_old_pytorch_support
branch
from
July 23, 2026 04:31
de2f2a8 to
e77614b
Compare
swahtz
approved these changes
Jul 23, 2026
swahtz
left a comment
swahtz
left a comment
Contributor
There was a problem hiding this comment.
Looks great, I'm always happy to remove code and dropping support for versions older than 2.6 seems reasonable to me. Thanks!
Contributor
|
Do any docs need to be updated? And fvdb-reality-capture? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyTorch 2.6 was released in January 2025 and introduced maps for strings <-> dtypes and a Python typecaster for dtypes. This PR removes the compatibility wrappers necessary for PyTorch versions prior to that thus dropping support for PyTorch < 2.6.
Note that our pyproject.toml already requires torch >= 2.8 and the latest PyTorch version is 2.13.