ci: use configuration variables for Docker Hub and Quay.io usernames - #212
Open
jefferyto wants to merge 1 commit into
Open
ci: use configuration variables for Docker Hub and Quay.io usernames#212jefferyto wants to merge 1 commit into
jefferyto wants to merge 1 commit into
Conversation
I believe recent build failures (openwrt#211) are caused by GitHub redacting the Docker Hub and Quay.io usernames inside Docker tag names passed to buildx. This changes the Docker Hub and Quay.io usernames to be stored as configuration variables[1], which are not redacted by GitHub, rather than as secrets. [1]: https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/use-variables#defining-configuration-variables-for-multiple-workflows Signed-off-by: Jeffery To <jeffery.to@gmail.com>
Member
Author
|
I should note that I'm only guessing this will fix #211 as I don't have a practical way to debug the issue or test this fix. I think it is a good idea in general to store the usernames as variables instead of as secrets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe recent build failures (#211) are caused by GitHub redacting the Docker Hub and Quay.io usernames inside Docker tag names passed to buildx.
This changes the Docker Hub and Quay.io usernames to be stored as configuration variables, which are not redacted by GitHub, rather than as secrets.