luci-app-rustdesk-server: fixes firmware update causes config loss - #8946
luci-app-rustdesk-server: fixes firmware update causes config loss#8946smallprogram wants to merge 1 commit into
Conversation
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit; commit message matches the diff. Three inline comments — the main one is that the new guard can never be true, because the package already ships the same section in /etc/config/rustdesk-server as a conffile.
Generated by Claude Code
402beb3 to
29abd53
Compare
|
request review and merge @jow- |
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit (force-push 402beb3 → 29abd53); the commit message still matches the diff.
The two substantive points from the previous review are addressed: the never-reachable guard is gone because the whole uci-defaults script is removed, and PKG_VERSION now moves 20260313 → 20260815 so the fix is actually reachable by apk/opkg upgrade. The shipped root/etc/config/rustdesk-server plus its conffiles registration in Makefile:13-15 still provide the defaults on fresh install and preserve user values across sysupgrade, so nothing is lost by the removal.
One documentation leftover flagged inline.
Generated by Claude Code
Fixes: openwrt#8935 This fixes the issue where configuration settings were lost during a firmware upgrade Signed-off-by: David Mandy <smallprogramzhusir@gmail.com>
29abd53 to
45bc5e0
Compare
|
This Claude Code is amazing. @efahl |
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit (force-push 29abd53 → 45bc5e0); no new issues found.
The only delta since the last review is the README architecture tree, which now drops the uci-defaults/50-luci-rustdesk-server line and promotes init.d/rustdesk-server to the last └── branch of the etc/ subtree — exactly the leftover flagged previously. No remaining references to the removed script anywhere in the package, and the commit message still matches the diff. CI on 45bc5e0 is green (build, eslint, FormalityCheck).
Generated by Claude Code
3 participants
Fixes #8935
This fixes the issue where configuration settings were lost during a firmware upgrade.
Pull request details
Description
fixes firmware update causes configuration loss.
Tested on
OpenWrt version: OpenWrt 25.12.2
LuCI version: LuCI openwrt-25.12 branch
Web browser(s): Chrome
Checklist