radicale3: fix versioned dependency - #8957
Conversation
|
Pending discussion in #8904. Marking as draft for now. |
openwrt-ai
left a comment
There was a problem hiding this comment.
Commit checks
- 06e7a4d "radiacle3: fix versioned dependency" — the subject scope is misspelled and matches no package in the tree. The commit touches
applications/luci-app-radicale3/Makefile, and the previous commit on that same file uses the full package name (luci-app-radicale3: fix (PKG_)PROVIDES). Suggested subject:luci-app-radicale3: fix versioned dependency. The same typo is in the PR title.
The code change itself checks out against the build system and in-tree usage:
EXTRA_DEPENDSset in an app Makefile beforeinclude ../../luci.mkis indeed ignored —Package/$(PKG_NAME)unconditionally re-derives it fromLUCI_EXTRA_DEPENDSinluci.mk:166, so the old line had no effect.-r<release>is the correct release separator:include/package-defaults.mk:26buildsVERSION:=$(PKG_VERSION)-r$(PKG_RELEASE), so3.7.1-1would never have matched.- The
pkg (>=x)spelling (space before(, none after>=) matches the only other in-tree user,luci-app-adguardhome/Makefile:11, and the space before(is required byFormatDependsin openwrt'sinclude/package-pack.mk:106for the APK path.
No other issues found in the diff.
Generated by Claude Code
The Makefile incorrectly used EXTRA_DEPENDS when it needs LUCI_EXTRA_DEPENDS. Fix that. Also, the version format was wrong (never noticed because LuCI wasn't actually using the versioned dependency). Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
06e7a4d to
376a4fd
Compare
|
|
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit (376a4fdd). It only amends the commit subject typo (radiacle3 → radicale3); the Makefile hunk is byte-identical to the one reviewed at 06e7a4dd, so the earlier analysis of the change still stands and I have no new findings on the code.
On the red build / Test x86_64 check at this head: the container step ends with ##[error]Process completed with exit code 2 and the artifact listing contains no luci-app-radicale3, radicale3 or rpcd-mod-rad3-enc apk — only luci-base and its own dependencies. Since LUCI_DEPENDS pulls in radicale3 (a Python package), that is consistent with the host-Python/ncurses SDK breakage you already described in the PR body and in the follow-up comment, not with this diff. Flagging it only so the record is explicit; no action implied.
Generated by Claude Code
Pull request details
Description
The Makefile incorrectly used EXTRA_DEPENDS when it needs LUCI_EXTRA_DEPENDS. Fix that.
Also, the version format was wrong (never noticed because LuCI wasn't actually using the versioned dependency).
Maintainer
@danielfdickinson @BKPepe
Tested on
Not available: Python host is currently not compiling under the SDK, for me.
Checklist
* No open issue
* No new dependency