Skip to content

radicale3: fix versioned dependency - #8957

Draft
danielfdickinson wants to merge 1 commit into
openwrt:masterfrom
danielfdickinson:pr-fix-radicale3-extra-depends
Draft

radicale3: fix versioned dependency#8957
danielfdickinson wants to merge 1 commit into
openwrt:masterfrom
danielfdickinson:pr-fix-radicale3-extra-depends

Conversation

@danielfdickinson

@danielfdickinson danielfdickinson commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Pull request details

Description

The Makefile incorrectly used EXTRA_DEPENDS when it needs LUCI_EXTRA_DEPENDS. Fix that.
Also, the version format was wrong (never noticed because LuCI wasn't actually using the versioned dependency).

Maintainer

@danielfdickinson @BKPepe


Tested on

Not available: Python host is currently not compiling under the SDK, for me.


Checklist

  • Includes what Issue it closes (e.g. openwrt/luci#issue-number).
    * No open issue
  • Includes what it depends on (e.g. openwrt/packages#pr-number in sister repo).
    * No new dependency

@danielfdickinson

Copy link
Copy Markdown
Contributor Author

Pending discussion in #8904. Marking as draft for now.

@danielfdickinson
danielfdickinson marked this pull request as draft August 20, 2026 10:20

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit checks

  • 06e7a4d "radiacle3: fix versioned dependency" — the subject scope is misspelled and matches no package in the tree. The commit touches applications/luci-app-radicale3/Makefile, and the previous commit on that same file uses the full package name (luci-app-radicale3: fix (PKG_)PROVIDES). Suggested subject: luci-app-radicale3: fix versioned dependency. The same typo is in the PR title.

The code change itself checks out against the build system and in-tree usage:

  • EXTRA_DEPENDS set in an app Makefile before include ../../luci.mk is indeed ignored — Package/$(PKG_NAME) unconditionally re-derives it from LUCI_EXTRA_DEPENDS in luci.mk:166, so the old line had no effect.
  • -r<release> is the correct release separator: include/package-defaults.mk:26 builds VERSION:=$(PKG_VERSION)-r$(PKG_RELEASE), so 3.7.1-1 would never have matched.
  • The pkg (>=x) spelling (space before (, none after >=) matches the only other in-tree user, luci-app-adguardhome/Makefile:11, and the space before ( is required by FormatDepends in openwrt's include/package-pack.mk:106 for the APK path.

No other issues found in the diff.


Generated by Claude Code

@danielfdickinson danielfdickinson changed the title radiacle3: fix versioned dependency radicale3: fix versioned dependency Aug 20, 2026
The Makefile incorrectly used EXTRA_DEPENDS when it needs
LUCI_EXTRA_DEPENDS. Fix that.
Also, the version format was wrong (never noticed because LuCI
wasn't actually using the versioned dependency).

Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
@danielfdickinson
danielfdickinson force-pushed the pr-fix-radicale3-extra-depends branch from 06e7a4d to 376a4fd Compare August 20, 2026 22:37
@danielfdickinson

danielfdickinson commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

curses foiled again! I'll re-run the checks on the this PR and other PRs tomorrow or the day after, when the ncurses issue is hopefully resolved.

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit (376a4fdd). It only amends the commit subject typo (radiacle3radicale3); the Makefile hunk is byte-identical to the one reviewed at 06e7a4dd, so the earlier analysis of the change still stands and I have no new findings on the code.

On the red build / Test x86_64 check at this head: the container step ends with ##[error]Process completed with exit code 2 and the artifact listing contains no luci-app-radicale3, radicale3 or rpcd-mod-rad3-enc apk — only luci-base and its own dependencies. Since LUCI_DEPENDS pulls in radicale3 (a Python package), that is consistent with the host-Python/ncurses SDK breakage you already described in the PR body and in the follow-up comment, not with this diff. Flagging it only so the record is explicit; no action implied.


Generated by Claude Code

Comment thread applications/luci-app-radicale3/Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants