luci-app-dockerman: fix logs missing spacebars - #8977
Open
jjm2473 wants to merge 1 commit into
Open
Conversation
openwrt-ai
reviewed
Aug 24, 2026
openwrt-ai
left a comment
openwrt-ai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed 1 new commit; one inline issue on the approach taken (see comment). Commit message matches its diff, and CI on 70abada is green.
Generated by Claude Code
add "white-space: pre-wrap;" as AI suggests Signed-off-by: Liangbin Lian <jjm2473@gmail.com>
jjm2473
force-pushed
the
pr-master/fix-dockermanjs-logs-spacebars
branch
from
August 25, 2026 03:49
70abada to
329f284
Compare
openwrt-ai
reviewed
Aug 25, 2026
openwrt-ai
left a comment
openwrt-ai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed 1 new commit. The escaping approach flagged last round has been replaced with white-space: pre-wrap; on the logs container, which addresses the wrapping regression and the tab-collapsing gap as well — ansiToHtml() already rewrites \r\n/\r/\n to <br/> before the string reaches the DOM, so pre-wrap won't double up line breaks. Commit message matches its diff. One nit inline; CI on 329f284 is green (x86_64 build still running).
Generated by Claude Code
Contributor
Author
|
ping @systemcrash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add "white-space: pre-wrap;" as AI suggests
Pull request details
Description
Fix logs missing spacebar on render.
Screenshot or video of changes (if applicable)
Before:
After:
Maintainer (preferred)
@systemcrash
Tested on
OpenWrt version: OpenWrt 25.12.5
LuCI version: LuCI openwrt-25.12 branch
Web browser(s): Chrome 151.0.7922.76
Checklist