Skip to content

mutt: update to 2.4.2 - #30396

Open
fromagium wants to merge 1 commit into
openwrt:masterfrom
fromagium:mutt-latest
Open

mutt: update to 2.4.2#30396
fromagium wants to merge 1 commit into
openwrt:masterfrom
fromagium:mutt-latest

Conversation

@fromagium

@fromagium fromagium commented Aug 30, 2026

Copy link
Copy Markdown

📦 Package Details

Maintainer: @philenotfound
Description: Changelog since last version: https://gitlab.com/muttmua/mutt/-/compare/mutt-2-1-5-rel...mutt-2-4-2-rel


🧪 Run Testing Details

  • OpenWrt Version: SNAPSHOT, r35836-20d94d5a2b
  • OpenWrt Target/Subtarget: Filogic 8x0 (MT798x)
  • OpenWrt Device: Bananapi BPi-R4

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit. Nothing blocking found.

The bump itself is well-formed: PKG_RELEASE is correctly reset to 1 alongside the PKG_VERSION change, PKG_HASH is updated in the same commit, and the package carries no in-tree patches that could have gone stale across 2.1.5 → 2.4.2. PKG_MAINTAINER, PKG_LICENSE and PKG_CPE_ID are untouched and still accurate. The unchanged CONFIGURE_ARGS still line up with the options this package exposes in Config.in, and all ten Feeds Package Test Build architectures plus the formality checks are green on c8ca1aa, which exercises the download hash and the configure/build path with the default POP/IMAP/OpenSSL selection.

Note that outbound access in this review environment is limited to GitHub, so I could not independently re-download the tarball from ftp.mutt.org to confirm PKG_HASH by hand — I am relying on the green CI build for that.

One non-blocking nit inline about the changelog range in the commit message.


Generated by Claude Code

Comment thread mail/mutt/Makefile
PKG_NAME:=mutt
PKG_VERSION:=2.1.5
PKG_RELEASE:=2
PKG_VERSION:=2.4.2

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the changelog link in the commit message and the PR body starts at mutt-2-1-3-rel, but the version being replaced here is 2.1.5 (see the - side of this hunk). As written the comparison silently omits everything between 2.1.3 and 2.1.5. Worth changing the range to mutt-2-1-5-rel...mutt-2-4-2-rel so the "changelog since last version" claim matches what is actually in the tree.


Generated by Claude Code

Changelog since last version: https://gitlab.com/muttmua/mutt/-/compare/mutt-2-1-5-rel...mutt-2-4-2-rel

Signed-off-by: Romain Isnel <ri@frmg.eu>

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit; no new issues found.

The force-push leaves mail/mutt/Makefile byte-identical to the version I reviewed at c8ca1aagit diff c8ca1aa..ac7ff0b is empty. The only change is in the commit message, where the changelog range was corrected from mutt-2-1-3-rel...mutt-2-4-2-rel to mutt-2-1-5-rel...mutt-2-4-2-rel, which resolves the nit from my previous review. The message header and body still match what the commit does.

Note that CI has not reported on the new head yet; since the tree is unchanged from c8ca1aa, the earlier green build still applies to this content.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants