hcxdumptool: update to version 7.1.2 - #30403
Conversation
Full changelog here: https://raw.githubusercontent.com/ZerBea/hcxdumptool/refs/tags/7.1.2/changelog Signed-off-by: Atanas Vladimirov <vladimirov.atanas@gmail.com>
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit. The commit message matches the diff, and PKG_RELEASE is correctly left at 1 for a version bump.
Note: I was unable to independently verify PKG_HASH against the codeload tarball from this environment, so that value is unchecked here. Tag 7.1.2 does exist upstream.
Generated by Claude Code
|
|
||
| PKG_NAME:=hcxdumptool | ||
| PKG_VERSION:=6.3.4 | ||
| PKG_VERSION:=7.1.2 |
There was a problem hiding this comment.
The 7.x series adds a second binary that this package builds but then throws away. Upstream 7.1.2 has TOOLS=hcxdumptool / TOOLS+=hcxnmealog at Makefile:38-39, whereas 6.3.4 built hcxdumptool only. Build/Compile here invokes the default all target, so hcxnmealog is compiled, but Package/hcxdumptool/install (Makefile:47-50) still installs hcxdumptool alone.
Was dropping hcxnmealog intentional (e.g. to keep the package small), or should the install section pick it up as well? If it is deliberate, restricting the build to hcxdumptool ($(MAKE) ... hcxdumptool) would avoid compiling it for nothing.
Generated by Claude Code
There was a problem hiding this comment.
Bumping this package across the 6.x → 7.x boundary on its own leaves it out of step with its sibling. Upstream states as a hard requirement: "Make sure that the version of hcxdumptool always fits to the version of hcxpcapngtool". hcxpcapngtool ships from hcxtools, which is still at PKG_VERSION:=6.3.2 in net/hcxtools/Makefile:11, and ZerBea/hcxtools has a matching 7.1.2 tag.
After this merges, a user with both packages installed gets hcxdumptool 7.1.2 feeding pcapng captures to hcxpcapngtool 6.3.2. Is a companion hcxtools: update to version 7.1.2 commit planned in this PR or a follow-up?
Generated by Claude Code
There was a problem hiding this comment.
nit: DEPENDS:=+libpcap +libopenssl at Makefile:27 pulls in libopenssl, but nothing in the source uses it. In the 7.1.2 tree, grepping the C sources, headers and upstream Makefile for openssl, SSL_, EVP_, -lssl and -lcrypto returns no hits, and the only link flag is LDFLAGS += -lpcap.
This is pre-existing (6.3.4 was equally free of OpenSSL, so the PR does not introduce it), but a version bump is the natural point to drop it — it currently forces libopenssl onto images that install hcxdumptool for no reason. Worth a PKG_RELEASE bump-free tidy-up in this commit, or a separate one if you would rather keep the diff minimal.
Generated by Claude Code
2 participants
📦 Package Details
Maintainer: @adde88>
Description:
Full changelog since the last update:
https://raw.githubusercontent.com/ZerBea/hcxdumptool/refs/tags/7.1.2/changelog
🧪 Run Testing Details
✅ Formalities