qemu: update to 11.1.1 - #30404
Conversation
401edad to
b22e827
Compare
|
|
8a0329f to
1e14db4
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit. The version bump itself looks consistent: PKG_RELEASE correctly reset to 1, python-setuptools/host matches how the rest of the feed declares that host dependency, and the two refreshed patches (0001, 0004) have well-formed hunk headers. All Feeds Package Test Build jobs are green on this head, which also exercises the reworked CONFIGURE_ARGS and the multiboot_dma.bin / linuxboot.bin firmware list on x86_64.
One question worth answering before merge, on the removal of 0003-qga-invoke-separate-applets-for-guest-shutdown-modes.patch — that one is a runtime behaviour change CI cannot catch, and it is the only bullet in the commit message without an upstream reference. Details inline. The other inline remark is a cosmetic nit and does not block anything.
Generated by Claude Code
- Update to 11.1.1 (10.1.x is EOL,ref https://wiki.qemu.org/Planning/10.1) - Refresh patches - Remove `0003-qga-invoke-separate-applets-for-guest-shutdown-modes.patch`, this issue has been fixed upstream, ref qemu/qemu@c5b4afd - `PKG_BUILD_DEPENDS` add `python-setuptools/host` - Remove `--disable-glusterfs`, 11.1 deprecated this,ref https://github.com/qemu/qemu/blob/stable-11.1/docs/about/removed-features.rst - Remove `linuxboot.bin`, change `multiboot.bin`to `multiboot_dma.bin`, ref qemu/qemu@e818b4b and qemu/qemu@88641f4 - Drop i386 support,ref qemu/qemu@25512d6 Changelog: https://www.mail-archive.com/qemu-devel@nongnu.org/msg1220561.html Signed-off-by: Andy Chiang <AndyChiang_git@outlook.com>
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit; no new issues found.
The only change since 1c4229a4 is dropping the space after := / += on the four QEMU_DEPS_IN_* lines. @AndyChiang888 is right and my earlier nit was wrong: FormalityCheck / OpenWrt Makefiles rejects a space after :=, so aligning the three QEMU_DEPS_IN_HOST lines downward was the correct resolution, not restoring the space on QEMU_DEPS_IN_GUEST. Sorry for the noise. Semantically it is a no-op — make strips leading whitespace after := and += either way — and all three FormalityCheck jobs plus the ten Feeds Package Test Build jobs are green on this head.
Nothing new to flag. The one open question from the previous round (whether 11.1's qga/commands-posix.c still needs 0003-qga-invoke-separate-applets-for-guest-shutdown-modes.patch for guest-shutdown to work on OpenWrt, where there is no /sbin/shutdown) is unchanged and is not re-posted here; it is a runtime behaviour question for the maintainer, not a blocker I can settle from the diff.
Generated by Claude Code
0003-qga-invoke-separate-applets-for-guest-shutdown-modes.patch,this issue has been fixed upstream, ref
qemu/qemu@c5b4afd
PKG_BUILD_DEPENDSaddpython-setuptools/host--disable-glusterfs,11.1 deprecated this,ref https://github.com/qemu/qemu/blob/stable-11.1/docs/about/removed-features.rst
linuxboot.bin, changemultiboot.bintomultiboot_dma.bin,ref qemu/qemu@e818b4b and
qemu/qemu@88641f4
Changelog: https://www.mail-archive.com/qemu-devel@nongnu.org/msg1220561.html
📦 Package Details
Maintainer: @yousong
Description:
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.