main: tear down the DNS ifb device on exit - #9
Open
choppyc79 wants to merge 1 commit into
Open
Conversation
qosify_dns_init() creates the ifb-dns netdev, but qosify_dns_stop() is never called, so the device and its default qdisc survive a clean shutdown of the daemon: # /etc/init.d/qosify stop # tc qdisc show dev ifb-dns qdisc fq_codel 0: dev ifb-dns root refcnt 2 limit 10240p flows 1024 [...] Per-interface ifb devices are already removed via interface_clear_qdisc(), so ifb-dns is the only leftover. It is most visible after removing the package, since nothing recreates or cleans it up afterwards. Call qosify_dns_stop() after qosify_iface_stop(), so that the filters redirecting to ifb-dns are gone before the device itself is deleted. This also closes the raw packet socket and frees the cname cache. Signed-off-by: Ash Clarke <clarkeaj@hotmail.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qosify_dns_init() creates the ifb-dns netdev, but qosify_dns_stop() is
never called, so the device and its default qdisc survive a clean
shutdown of the daemon:
/etc/init.d/qosify stop
tc qdisc show dev ifb-dns
qdisc fq_codel 0: dev ifb-dns root refcnt 2 limit 10240p flows 1024 [...]
Per-interface ifb devices are already removed via interface_clear_qdisc(),
so ifb-dns is the only leftover. It is most visible after removing the
package, since nothing recreates or cleans it up afterwards.
Call qosify_dns_stop() after qosify_iface_stop(), so that the filters
redirecting to ifb-dns are gone before the device itself is deleted.
This also closes the raw packet socket and frees the cname cache.
Signed-off-by: Ash Clarke clarkeaj@hotmail.co.uk