ci: run Sonar on fork PRs via pull_request_target - #3500
Closed
csviri wants to merge 1 commit into
Closed
Conversation
Sonar never ran on PRs: the job was gated on head.repo.owner.login == 'operator-framework', which is false for fork PRs (all contributions), and plain pull_request from forks doesn't expose SONAR_TOKEN anyway. Switch to pull_request_target so the job runs in the base-repo context with secrets, check out the PR head so we analyze the proposed change, pass explicit sonar.pullrequest.* properties (auto-detection reflects the base branch under pull_request_target), and key concurrency by PR number so PRs don't cancel each other.
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
67
to
73
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sonar never ran on PRs: the job was gated on
head.repo.owner.login == 'operator-framework', which is false for
fork PRs (all contributions), and plain pull_request from forks
doesn't expose SONAR_TOKEN anyway.
Switch to pull_request_target so the job runs in the base-repo
context with secrets, check out the PR head so we analyze the
proposed change, pass explicit sonar.pullrequest.* properties
(auto-detection reflects the base branch under pull_request_target),
and key concurrency by PR number so PRs don't cancel each other.