Close kernel conformance freshness and authority gaps - #207
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex automated review
Verdict: patch is incorrect
Confidence: 0.98
The new conformance expiry case rejects valid authority lifetimes, while the revised repository verifier misses common Go identifier forms that the prior check caught. Model-level verification is not recommended; both defects have direct deterministic regression tests.
There was a problem hiding this comment.
Codex automated review
Verdict: patch is incorrect
Confidence: 0.94
The new verifier can miss forbidden GitHub coupling and can report independent freshness coverage when fixture hooks perturb additional freshness dimensions. Model-level verification is not recommended before merge because these are local verifier defects with direct regression oracles.
There was a problem hiding this comment.
Codex automated review
Verdict: patch is incorrect
Confidence: 0.96
The freshness and authority conformance additions appear consistent, but the replacement vocabulary verifier regresses soundness. Model-level verification is not recommended for this localized issue.
There was a problem hiding this comment.
Codex automated review
Verdict: patch is incorrect
Confidence: 0.97
The conformance additions appear internally consistent, but the strengthened domain-neutrality verifier is unsound in both directions: it misses aliased domain-specific imports and rejects valid identifiers in newly scanned test files. Model-level verification is not recommended because the defects are confined to the static verifier.
There was a problem hiding this comment.
Codex automated review
Verdict: patch is incorrect
Confidence: 0.97
The new source-vocabulary verifier is unsound for import-attached comments and incomplete for valid neutral test identifiers. The conformance freshness and authority changes otherwise show no established defect. Model-level verification is not recommended; these are localized parser/matcher issues.
| case *ast.ImportSpec: | ||
| return false |
There was a problem hiding this comment.
[P3] Import-attached comments bypass the vocabulary guard
Invariant: every forbidden domain token in kernel source comments must be detected. A production file containing import "fmt" // repository adapter followed by a normal fmt use passes domain_vocabulary_hits: returning false for *ast.ImportSpec skips its Doc and Comment children, while fmt contributes no import-path hit. The previous raw-source check rejected this token, so the bypass is introduced here and makes the domain-neutrality CI guard unsound. Add a fixture with an import-line comment and require a repository hit; inspect import comments while excluding only the path literal.
Confidence: 0.99
| for root, token in DOMAIN_NEUTRAL_ROOTS: | ||
| if normalized == root or normalized.startswith(root): | ||
| return token |
There was a problem hiding this comment.
[P3] Prefix matching rejects neutral branching tests
Invariant: the domain-neutrality verifier must accept identifiers using branch in its ordinary control-flow sense. Adding boatstack/kernel/relation_test.go with func TestBranchingCandidates(t *testing.T) now fails CI: Branching is split as one component and startswith("branch") classifies it as a Git branch reference. This is introduced because the patch extends vocabulary scanning to _test.go files. The observable impact is that valid kernel tests cannot merge. Add a fixture expecting no hits for TestBranchingCandidates, and match semantic identifier components rather than arbitrary root prefixes.
Confidence: 0.96
1 participant
Summary
Motivation
This follows the final review findings on merged PR #205:
Verification
go test -race ./kernel/... -count=20 -timeout=3mgo vet ./...go build ./...git diff --checkBoatstack Review Trial 1: READY with two closure passes.
Locus: faithful, advisory, forbidden states unreachable, zero blocking states.
Derivation:
drv-9f120b09b90f05d37e1cfb202073b74652c2ca9726500752e3c5b4f8f7acd67e