Skip to content

Bind declarative state effects to admission and target law - #209

Merged
bigboateng merged 3 commits into
mainfrom
fix/declarative-state-effect-boundaries
Aug 12, 2026
Merged

Bind declarative state effects to admission and target law#209
bigboateng merged 3 commits into
mainfrom
fix/declarative-state-effect-boundaries

Conversation

@bigboateng

@bigboateng bigboateng commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #208. Remote review found four control-boundary gaps in the declarative state-effect implementation.

This change:

  • derives product mutation capability from owned facets instead of effect-name prefixes;
  • requires an assignment to satisfy every target condition for its facet;
  • reconstructs recovery write authority from the admission-bound capability identity instead of mutable journal data; and
  • preserves the current schema-8 journal shape across runtime activation while treating its recorded facet envelope as evidence only.

Regression coverage includes arbitrary product effects, conjunctive target conditions, admission-bound recovery, schema-8 pending update recovery, and committed-journal idempotent replay.

Verified locally with the full Go suite under the race detector, repository contract tests, release-note validation, vet, build, and diff checks.

@cursor

cursor Bot commented Aug 12, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex automated review

Verdict: patch is incorrect
Confidence: 0.99

The journal downgrade breaks the immediate base-to-head migration boundary and can strand an update after runtime activation or block repositories with existing committed facts. Model-level verification is recommended before merge: verify every interruption point around runtime activation remains recoverable across all supported journal versions.

Comment thread boatstack/internal/softwaredelivery/protocol/journal.go Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex automated review

Verdict: patch is correct
Confidence: 0.88

No actionable patch-introduced defect was established. Resolver targets, capability classification, facet ownership, and recovery write envelopes remain aligned. Model-level verification is recommended for cross-version schema-8 recovery reachability, especially interrupted installation reconciliation.

@bigboateng
bigboateng merged commit eea96ec into main Aug 12, 2026
17 checks passed
@bigboateng
bigboateng deleted the fix/declarative-state-effect-boundaries branch August 12, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant