Skip to content

Fix release finalizer receipt lookup #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bigboateng merged 1 commit into from
Aug 8, 2026
Merged

Fix release finalizer receipt lookup #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions .github/workflows/release-finalize.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,15 +91,23 @@ jobs:
run: |
set -euo pipefail
version="${TAG#v}"
run="$(gh api "/repos/${GITHUB_REPOSITORY}/actions/workflows/npm-publish.yml/runs?head_sha=${SOURCE_SHA}&status=completed&per_page=30" \
--jq '[.workflow_runs[] | select(.event == "workflow_dispatch")][0] // {}')"
test "$(jq -r '.conclusion // "missing"' <<< "$run")" = success
run_id="$(jq -r '.id // empty' <<< "$run")"
package_receipt="packages-${version}-${SOURCE_SHA}"
crates_receipt="crates-${version}-${SOURCE_SHA}"
run_id=""
while read -r candidate; do
test -n "$candidate" || continue
artifact_names="$(gh api "/repos/${GITHUB_REPOSITORY}/actions/runs/${candidate}/artifacts?per_page=100" --jq '.artifacts[].name')"
if grep -Fqx "$package_receipt" <<< "$artifact_names" && grep -Fqx "$crates_receipt" <<< "$artifact_names"; then
run_id="$candidate"
break
fi
done < <(gh api "/repos/${GITHUB_REPOSITORY}/actions/workflows/npm-publish.yml/runs?status=completed&per_page=100" \
--jq '.workflow_runs[] | select(.event == "workflow_dispatch" and .conclusion == "success") | .id')
test -n "$run_id"
gh run download "$run_id" --repo "$GITHUB_REPOSITORY" \
--name "packages-${version}-${SOURCE_SHA}" --dir "$RUNNER_TEMP/release-unit"
--name "$package_receipt" --dir "$RUNNER_TEMP/release-unit"
gh run download "$run_id" --repo "$GITHUB_REPOSITORY" \
--name "crates-${version}-${SOURCE_SHA}" --dir "$RUNNER_TEMP/crates-receipt"
--name "$crates_receipt" --dir "$RUNNER_TEMP/crates-receipt"
for package in \
@operatorstack/yield \
@operatorstack/create-yield \
Expand Down
15 changes: 12 additions & 3 deletions scripts/check-release-control.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,16 @@ export async function checkReleaseControl(root = resolve(import.meta.dirname, ".
"automatic finalization must ignore canary publisher runs",
)
expect(
raw["release-finalize.yml"].includes('select(.event == "workflow_dispatch")'),
"finalization must select only stable publisher receipts",
raw["release-finalize.yml"].includes(
'select(.event == "workflow_dispatch" and .conclusion == "success")',
),
"finalization must select only successful stable publisher receipts",
)
expect(
raw["release-finalize.yml"].includes("artifacts?per_page=100") &&
raw["release-finalize.yml"].includes('grep -Fqx "$package_receipt"') &&
raw["release-finalize.yml"].includes('grep -Fqx "$crates_receipt"'),
"finalization must select the publisher receipt by its exact source-bound artifact names",
)
expect(
raw["release-finalize.yml"].includes("--draft=false"),
Expand Down Expand Up @@ -290,7 +298,8 @@ export async function checkReleaseControl(root = resolve(import.meta.dirname, ".
"Go finalization must bind the module to the release source",
)
expect(
raw["release-finalize.yml"].includes('--name "crates-${version}-${SOURCE_SHA}"'),
raw["release-finalize.yml"].includes('crates_receipt="crates-${version}-${SOURCE_SHA}"') &&
raw["release-finalize.yml"].includes('--name "$crates_receipt"'),
"finalization must consume the publisher-produced crates receipt",
)
expect(
Expand Down