Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 142071b551
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
개발 목표·개발 기록 Domain 계약의 Firestore 저장 경계 구성과 기록 Draft·version 변경 transaction 제어
목표 완료의 최종 판정을 서버로 분리하기 위한 iOS 직접 완료 저장 제한
📝 작업 내용
📌 요약
baseVersionId기준 Draft 저장 정책 반영goalId저장 지원TodoQueryService와TodoCommandService로 분리completed상태의 iOS 직접 저장 제한🔍 상세
개발 목표 저장
inProgress·archived상태 전환만 허용completed·completedAt값의 조회 유지개발 기록 저장
baseVersionId일치 여부를 transaction 내부에서 확인baseVersionId기반 Draft 저장의 마지막 저장 결과 우선 정책 반영initial, 정정의correction, 이전 version 복원의rollbackversion 생성currentVersionId갱신의 단일 transaction 처리개발 기록 확정 버전의 변경을 차단한다 DevLog_Firebase#99
Todo 목표 연결
TodoRequest·TodoResponse와 Domain 매핑에 선택적goalId추가goalId저장goalId복원goalId필드 삭제Todo 조회·명령 분리
TodoService를TodoQueryService와TodoCommandService로 분리WidgetTodoSnapshotRepositoryImpl의 조회 서비스 의존으로 한정완료 권한 분리
completed전환 제한개발 목표 완료 최종 판정을 서버 transaction으로 일원화한다 DevLog_Firebase#101
📸 영상 / 이미지 (Optional)
해당 없음