chore(codegen): remove completed g4 port trackers - #339
Merged
Conversation
Native grammar parsing is now established and covered by executable regression fixtures, so the migration ledger no longer protects an active cutover. Remove the upstream and external inventories, port-evidence archive, map-driven fixture generators and validators, and the CI history wiring that maintained them. Keep the 471 behavior fixtures, move the frontend corpus to antlr-rust-g4-parser, and rename Phase C metadata as permanent runtime conformance coverage.
Copy/Paste DetectionNo duplications found in 4 changed non-generated Rust file(s) (threshold: 100 tokens). |
Code review:
|
Contributor
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8314e04211
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The relocated corpus lives under antlr-rust-g4-parser, while the Rust snapshot consumer resolves paths from that crate's manifest directory. Store case paths relative to the crate and give the updater an explicit repository-relative source root. Add a regression test that keeps corpus paths aligned with the generated TSV and verifies every referenced fixture exists.
The port-evidence validator no longer needs full history, but the independent Mehen step still compares source metrics against the PR base. Keep the checkout full-depth and document that remaining dependency.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
📊 Source Code Metrics (this PR vs
|
| File | Cyclomatic | Cognitive | Functions | LLOC | MI |
|---|---|---|---|---|---|
| crates/antlr-rust-g4-parser/src/frontend.rs | 225 (main: 217) 🔴 | 91 (main: 88) 🔴 | 70 (main: 68) 🔴 | 325 (main: 307) 🔴 | 0 ⚪ |
| crates/antlr-rust-g4-parser/src/lib.rs | 1 ⚪ | 0 ⚪ | 0 ⚪ | 0 ⚪ | 52.57 (main: 51.07) 🟢 |
| crates/antlr-rust-g4-parser/src/ported_tests.rs | 0 (was: 5) 🟢 | 0 (was: 2) 🟢 | 0 (was: 1) 🟢 | 0 (was: 10) 🟢 | 0 (was: 29.74) 🔴 |
Generated by mehen v1.8.1 — the code quality watcher.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.g4port inventories, evidence archive, generators, and validatorsantlr-rust-g4-parserWhy
The port-completeness machinery protected the one-time transition from
.interpinputs to native.g4compilation. Native parsing has now shipped through several releases and is covered directly by the retained regression fixtures, so continuing to maintain the historical ledger adds repository weight and CI complexity without protecting a live migration.The CI checkout remains full-depth because the independent Mehen source-metrics step compares the PR against its base revision.
Validation
cargo fmt --all -- --checkcargo test --locked --workspace --all-targets --all-featurescargo clippy --locked --workspace --all-targets --all-features -- -D warningsnode tools/grammar-frontend/validate-interp-fixtures.mjscargo check --manifest-path benches/Cargo.toml --benchesactionlint .github/workflows/ci.ymltools/release/check-workspace-version.shANTLR_RUST_RELEASE_ALLOW_DIRTY=1 tools/release/preflight-package-archives.shThe frontend snapshot oracle was not regenerated because the optional cleanroom
antlr-ngcheckout was not present. Its checked-in corpus paths and the fullantlr-rust-g4-parsersnapshot suite were validated successfully.