[Alnusjaponica]

Summary

Follow-up to #212: align the sampler type name with the NsgaiiBuilder naming (per the discussion with ozaki-san and PE baba-san).

Changes

• rustuna_sampler::nsgaii::NSGAIISampler → rustuna_sampler::nsgaii::NsgaiiSampler2
  • struct, Default, Sampler impl, NsgaiiBuilder2::build, new, seed_from_u64 signatures, and the tests in nsgaii.rs
  • doc examples updated accordingly
• rustuna_pyo3: PyNSGAIISampler2 → PyNsgaiiSampler (src/sampler/nsgaii.rs, study.rs, lib.rs)
• rustuna_sampler/benches/nsgaii.rs: bench uses NsgaiiSampler::default()

Unchanged (Rust-only rename):

• The Python-visible class name rustuna.samplers.NSGAIISampler (#[pyclass(name = "NSGAIISampler2")]), .pyi stubs, rustuna/samplers.py, Python tests, and docs
• The parent cache key prefix "NSGAIISampler2:parent:"
• References to Optuna's NSGAIISampler in doc comments

Verification

• cargo clippy --locked --workspace --lib --bins --tests --examples --all-features -- -D warnings — clean
• cargo test --locked --all-features — pass
• cargo fmt --all -- --check — clean
• cargo +nightly bench --no-run — bench compiles (uses NsgaiiSampler::default())
• Python: uv run pytest tests/ — 701 passed, 18 skipped
• cargo test -p rustuna_storage --locked -- --ignored — 3 pass

[Copilot]

Copilot review overview

🟡 Changes recommended

The PR description incorrectly documents several renamed symbols with a nonexistent 2 suffix.

Review effort: Balanced
Findings: 1

Open (1)

• Correct PR description to reference actual sampler API names · New

What changed in this PR

Renames the Rust NSGA-II sampler types while preserving the Python-visible API.

Changes:

• Renames NSGAIISampler to NsgaiiSampler.
• Updates Rust benchmarks, tests, documentation, and PyO3 internals.
• Retains Python class name NSGAIISampler.

File	Description
rustuna_sampler/​src/​nsgaii.rs	Renames the sampler and references.
rustuna_sampler/​benches/​nsgaii.rs	Updates benchmark usage.
rustuna_pyo3/​src/​study.rs	Updates PyO3 sampler resolution.
rustuna_pyo3/​src/​sampler/​nsgaii.rs	Renames the internal Python wrapper.
rustuna_pyo3/​src/​lib.rs	Registers the renamed wrapper.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[c-bata]

LGTM.