Repository navigation
Build TPE observation buffers column by column - #275
Merged
Merged
Conversation
- Traverse each column before moving to the next parameter. - Keep input and output buffers local while fitting good and poor models. - Preserve chronological values, missing-parameter checks, and row weights.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build TPE observation buffers one parameter column at a time to keep reads and writes within each column. Preserve chronological values, missing-value handling, and per-trial counts used for weights.
Closes #268.
Original implementation by @tkng, cherry-picked from 6e0975c with the original commit author preserved. The commit linked in the issue is no longer fetchable; this commit in the author's later history contains the loop-order change described there.