Repository navigation
Score TPE acquisition candidates as ordered arrays - #280
Merged
Merged
Conversation
- Generate candidates in the model's sorted parameter order. - Avoid parameter-name hashing and string copies during candidate generation and scoring. - Share generation and density calculations with the named sample API. - Convert only the winning candidate to the public parameter map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate and score TPE acquisition candidates as arrays in the models' shared parameter order, avoiding parameter-name hashing and string copies for discarded candidates. Convert only the winning candidate to a parameter map, while sharing sampling and density calculations with the existing named API.
Closes #269.
Original implementation by @tkng, cherry-picked from e4b4aab without code changes, preserving the original commit author.