Create the host socket with mode 0600 from the start - #2
Merged
Merged
Conversation
The host set 0600 in its listening callback, so a client could briefly see the socket at its creation mode. The directory is private, so nothing was exposed, but Linux CI caught the window. A 0o177 umask around the synchronous bind closes it. The test harness also ignores a broken pipe to a host it has just killed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.2.1 Release workflow failed on Linux CI in two host tests that pass on macOS:
0o177umask (the bind insidelistenis synchronous), so the socket is 0600 from the moment it exists. The chmod stays as a second guard.The extension package is unchanged, so the Chrome Web Store submission (0.2.1, pending review) is not affected.