Point the reviewer demo at the Browser Control site - #5
Merged
Merged
Conversation
example.com no longer shows "Example Domain" in its body text, and a script now splits its text into single letters, so the demo's wait timed out. The demo opens https://browser-control.pages.dev/, which runs no scripts, and waits for its first sentence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reviewer demo (step 7) timed out: example.com no longer shows "Example Domain" in its body text, and a script on the page now splits its text into single letters. The demo now opens https://browser-control.pages.dev/, which runs no scripts, and waits for its first sentence.
store/reviewer-test-instructions.mdandsite/support/reviewers/index.htmlstay word-for-word identical. The site is redeployed after the merge.