Repository navigation
feat(claude): apply frozen platform model bindings - #3
Draft
wanglongan587 wants to merge 1 commit into
Draft
wanglongan587 wants to merge 1 commit into
wanglongan587 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Requires the startup contract in desktop#703. Draft dependency: JSR currently publishes SDK 0.10.0. After 0.11.0 is published, update the formal SDK pin and lock file, rerun normal checks, then request final review. No unpublished JSR version is invented here.
Legacy starts stay unchanged. Active model discovery reads only the frozen binding. Provider/model replacement is refused; private diagnostics are suppressed while protocol error codes and Effect restart behavior are retained.
ADR: plugin-owned-model-adapters remains approved. Declaration publication stays opt-in and disabled by default; host rollout and final production acceptance are separate.
Refs ora-space/circus#336
Evidence
After: full source checks against the SDK preview, lint, and 30 tests pass; missing bundled executables fail without local/PATH fallback.
Merge Danger
Door: two-way
Code is reversible. SDK/package publication is a separate owner action; no release or declaration switch is performed.
Blast Radius: claude-adapter
Do not merge until the published SDK pin/lock and CI are updated. The model path supplies tokens through the child environment; programmatic settings contain no token literal because the pinned SDK serializes them into CLI arguments.
Refs ora-space/circus#354