Repository navigation
Conversation
This was referenced Oct 23, 2026
HappyAuratus
approved these changes
Oct 23, 2026
HappyAuratus
left a comment
Contributor
There was a problem hiding this comment.
已审查 commit e3bc1a6,未发现阻断问题。
核对全部 3 个文件及 desktop main e177e02 的 Node 协议:omitted_rejections 为 uint32/字段 3,walk_truncated 为 bool/字段 4,candidate_limit 追加为枚举值 9;语义、类型与 Node 一致,既有编号和默认值兼容。生成 descriptor、枚举映射、getter 与 proto 一致,wire round-trip 覆盖非默认完整性事实和拒绝原因。
本地 go test ./internal/controlgrpc/... ./internal/controlpb/... 通过(controlpb 无测试文件),git diff --check 通过。该 SHA 六项 CI 全绿,包含 buf lint/breaking 与生成漂移检查;本机没有 buf,未独立重跑。
结论仅覆盖契约先行切片;Cloud codec/持久化(#154)、Controller/Node 接线与真实跨栈验收仍须后续独立审查,不代表 #536 整体完成。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs ora-space/circus#536
Summary
Preserve whether a scheduled artifact manifest is complete across the Cloud control contract.
These additions match the executor's bounded collector. Regenerate the Go bindings and pin a
protobuf wire round trip. Merge this contract slice before consumers upgrade their Cloud submodule;
the Cloud codec/persistence implementation and Controller mapping consume it in follow-up changes.
ADR: additive wire portion of
specs/decisions/cloud/scheduled-task/20261022-run-verdict-and-artifacts.md(D3). The ADR remainsapproved; runtime delivery, projections and cross-stack acceptance are not completed by this PR.
Evidence
executor's truncation facts or
candidate_limitreason.After:
TestScheduledManifestCompletenessWireRoundTrippreserves both facts and the reason.buf lint,buf breakingagainst the current main contract, regeneration and the focused Go test pass.Merge Danger
Door: two-way
Blast Radius: contract
Additive fields and enum value only; existing field numbers and legacy zero/default behavior remain.
This slice does not start emitting new work or change runtime persistence.