Stream compilation errors - #68
Merged
Merged
Conversation
…ntly A submitted script that failed to compile previously threw out of the websocket frame handler, killing the connection with nothing sent back to the client. Now each stack in a submission is compiled independently; failures are reported back as a StackStateEvent carrying the new CompilationError contract (shared in nebula-api), recorded in the admin failedSubmissions snapshot, and the socket stays alive for subsequent submissions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ilently DatabaseExecutor ran table DDL and seed data AFTER the guarded container-start block had already emitted Running: invalid DDL threw out of the stack's start thread, killing it silently while the component kept reporting a healthy state. The DDL/data-load now runs inside the guarded init step, so a failure emits Failed with the database's error message (which flows over /stream/stacks to clients), and Running is only re-emitted after componentInfo is built when the init step succeeded. NebulaStack.startComponents also guards each component's start so one broken component can no longer kill the start thread or prevent the stack's remaining components from starting. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for orbital-nebula canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.