fix(work-items): restore Agent Workflow role translation - #678
Open
beruro wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Agent Workflow session-history cards rendered the literal key
workItems.agentWorkflow.roleCodinginstead of a translated role label.ROLE_I18N_KEYSreferencedroleCoding, but that key does not exist in any projects locale. The existing canonical key for both coding and SDE roles isroleSde, which the navigation sidebar already uses.Solution
Map both
codingandsdeworkflow roles toworkItems.agentWorkflow.roleSde.Add an i18n contract test that resolves every workflow role and status mapping across all 13 projects locales, preventing future mapping keys from silently falling back to raw text.
Potential risks
This changes only the translation-key mapping for coding and SDE history labels. No locale content, persisted data, API shape, or workflow behavior changes. The visible label becomes the existing localized
roleSdevalue in every supported locale. Rollback is a direct revert of this commit.Verification
npx vitest run src/modules/ProjectManager/WorkItems/components/AgentWorkflow/__tests__/agentWorkflowI18n.test.ts— 1 test passed across all 13 locale resources.npx tsc --noEmit --pretty false— passed.git diff --check— passed.UI evidence
No new screenshot was captured because the reported screenshot already demonstrates the exact raw-key failure and the user requested that this task not control the UI image. The fix replaces that invalid mapping with the same existing localized key already used by the sidebar.
This is a single-file UI bug fix, so the repository guidance explicitly excludes it from the broader frontend UI audit.