chore: adopt shared engineering standards - #2
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
CI will remain failing because just check continues to validate the pinned Gerber export that still violates the blocking C-02 keep-out rule described in #1.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adopts the shared Origin89 engineering guidance by adding a task-start skill refresh mechanism (cached and ignored), standardizing local developer/CI setup around just, and locking Python validation dependencies with hashes so the Gerber validation can run consistently in CI and locally.
Changes:
- Add
just skills-syncbootstrap wiring plus local docs (AGENTS.md,CLAUDE.md,CONTRIBUTING.md) to align with shared engineering standards while keeping repo-specific constraints. - Lock validation dependencies via
requirements-dev.in→ hash-pinnedrequirements-dev.txt, and update CI to install with--require-hashes. - Route CI validation through
just check(which runs the pinned Gerber validation against the committed export).
File summaries
| File | Description |
|---|---|
requirements-dev.txt |
Adds a hash-locked dependency set for reproducible board validation installs. |
requirements-dev.in |
Defines the small, human-edited inputs for regenerating the locked requirements file. |
justfile |
Introduces skills-sync and standardizes validation entrypoints via just check. |
CONTRIBUTING.md |
Documents the new bootstrap flow, required tool versions, and dependency regen command. |
CLAUDE.md |
Points agents/tools at AGENTS.md as the primary task-start instructions. |
AGENTS.md |
Adds repo-local, task-start and board-work constraints aligned to shared standards. |
.origin89/sync-engineering.py |
Implements safe download/verification/caching of shared skills into an ignored local snapshot. |
.gitignore |
Ensures cached skills and local environment artifacts aren’t committed. |
.github/workflows/check.yml |
Updates CI to install pinned deps, set up just, and run just check. |
.github/pull_request_template.md |
Adds a structured PR template emphasizing validation evidence and completeness. |
Review details
- Files reviewed: 9/10 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt the shared Origin89 engineering guidance through a task-start skill refresh. Each repository keeps its local constraints and checks; shared skills are downloaded into an ignored, verified cache instead of copied into version control.
Run the existing camera validation through
just checklocally and in CI. Lock Python dependencies with hashes, pin just, and retain the immutable fabrication export and camera-specific rules.Validation:
just check: the archived export still fails the existing C-02 mounting-hole copper keep-outs documented in Ground pour reaches all four mounting holes (C-02, C-03) #1. The check remains blocking; no rule or tolerance was weakened.git diff --checkpass.Draft because the existing artwork gate is red. This change does not modify artwork or claim bench qualification.