Skip to content

A cell printing several models' values is stored whole under each model #183

Description

@lemarier

Some tables print several models' values in one cell, separated by slashes, in the order of the column heading. The text reader stores the whole cell as one model's value. The prompt already says "400 W, 1000 W and 2000 W" is three products' figures written together, and nothing in the pull catches a value that breaks that rule.

Examples from pull #174, checked against the converted text of Victron's catalogue (doc-2a8650d668cef6cc5a78c92979a11aa1):

  • p63, "MultiPlus 12 Volt/24 Volt: 12/2000/80 24/2000/50 12/3000/120 24/3000/70". victron-energy-12-2000-80--charge-current-house-battery holds "80 / 50 A", where 50 A belongs to the 24/2000/50. Its maximum efficiency, zero load power, AES mode and search mode figures hold the same kind of two-model cell.
  • p63, same table. victron-energy-24-3000-70--charge-voltage-absorption, --float, --storage-mode, --maximum-efficiency, --charge-current-house-battery and three zero-load figures hold both halves: "14,4 / 28,8", "120 / 70" and so on. Where the halves are equal ("20 / 20") the stored value is still two models' value.
  • p83, "SmartShunt IP65 300 A / 500 A / 1000 A / 2000 A". victron-energy-smartshunt-ip65-300-a--offset, and the 500 A, 1000 A and 2000 A offsets, each hold "Less than 10 / 10 / 20 / 40 mA". Taken in heading order, the printed values are 10, 10, 20 and 40 mA.

Expected: each model gets its own part of the cell, or the figure is left out when the parts cannot be matched to the heading.

Actual: every model in the heading gets the whole cell. A consumer reading "80 / 50 A" cannot tell which number is this product's.

Next step: add a pull check that refuses a value made of N slash-separated parts when the model's table heading lists N products separated the same way. Keep single-product values such as "12/24" and "50 / 60Hz", which the prompt says stay as printed. Then decide whether the reader should split the cell itself.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions