A figure's value sometimes carries a piece of the reader's own answer structure, such as ', 'unit': or , unit:, and nothing refuses it. looksTruncated refuses a value with a brace or bracket, or one ending in a comma or semicolon, and looksGarbled refuses the symbols the reader writes in place of one it cannot copy (#145). Neither covers a value that ends mid-key.
In pull #187, 15 figures from Progressive Dynamics' PD1600 quick reference guide, five names for each of PD1610, PD1618 and PD1620:
progressive-dynamics-pd1610--max-power = 1000W', 'unit':progressive-dynamics-pd1610--frequency = 60 Hz', 'unit':progressive-dynamics-pd1610--peak-efficiency = 90%', 'unit':progressive-dynamics-pd1610--transfer-voltage = 95 - 135 VAC', 'unit':progressive-dynamics-pd1610--waveform = Pure Sine Wave', 'unit':
The numbers themselves are what page 7 prints. The same artifact is already on main, in 17 figures no one has reviewed:
- 15 OutBack NorthStar figures ending
, unit:, such as outback-power-northstar-nsb40ft-blue--weight = 31 lb, unit:
pentair-7clm--overall-dimensions = 20.70" L x 3.34" dia', '52.58 x 8.48 cmsol-ark-l3-hvr-60kwh-30k--ac-input-output-voltage = 120/208V a.c.', 'unit': 'V
Expected: a value that carries part of the answer's structure is refused, like a truncated or garbled one, and counted in the pull's output.
Actual: it is written as the printed value. splitValueUnit then finds no unit, so the figure also loses the unit it was printed with, and the property layer reads the value as unparsed rather than as a gap.
Next step: widen the refusal in src/units.ts to a value that carries a quoted key or ends mid-key, with those values as test cases, and correct or reject the 32 figures that already have one.
A figure's value sometimes carries a piece of the reader's own answer structure, such as
', 'unit':or, unit:, and nothing refuses it.looksTruncatedrefuses a value with a brace or bracket, or one ending in a comma or semicolon, andlooksGarbledrefuses the symbols the reader writes in place of one it cannot copy (#145). Neither covers a value that ends mid-key.In pull #187, 15 figures from Progressive Dynamics' PD1600 quick reference guide, five names for each of PD1610, PD1618 and PD1620:
progressive-dynamics-pd1610--max-power=1000W', 'unit':progressive-dynamics-pd1610--frequency=60 Hz', 'unit':progressive-dynamics-pd1610--peak-efficiency=90%', 'unit':progressive-dynamics-pd1610--transfer-voltage=95 - 135 VAC', 'unit':progressive-dynamics-pd1610--waveform=Pure Sine Wave', 'unit':The numbers themselves are what page 7 prints. The same artifact is already on main, in 17 figures no one has reviewed:
, unit:, such asoutback-power-northstar-nsb40ft-blue--weight=31 lb, unit:pentair-7clm--overall-dimensions=20.70" L x 3.34" dia', '52.58 x 8.48 cmsol-ark-l3-hvr-60kwh-30k--ac-input-output-voltage=120/208V a.c.', 'unit': 'VExpected: a value that carries part of the answer's structure is refused, like a truncated or garbled one, and counted in the pull's output.
Actual: it is written as the printed value.
splitValueUnitthen finds no unit, so the figure also loses the unit it was printed with, and the property layer reads the value as unparsed rather than as a gap.Next step: widen the refusal in
src/units.tsto a value that carries a quoted key or ends mid-key, with those values as test cases, and correct or reject the 32 figures that already have one.