Skip to content

ci: ocr-review races the ocr wrapper's self-update #39

Description

@lemarier

The reusable ocr-review.yml (called by origin89hq/firmware at 176197a) failed on origin89hq/firmware#257 with ocr: command not found (exit 127) in the "Run OpenCodeReview" step, two seconds after "Install OpenCodeReview" had installed v1.12.9 and read its version: https://github.com/origin89hq/firmware/actions/runs/36403813174 (attempt 1). A re-run of the same job passed and posted its review.

Likely cause (inferred from the log, not reproduced): the npm build's ocr wrapper starts a background npm i -g self-update on every run unless OCR_NO_UPDATE=1 is set. The install step calls ocr version without it, and the job's cleanup shows "Terminate orphan process: pid (2414) (npm i @alibaba-)", so the background reinstall was still replacing the global package when the review step called ocr.

Next step: set OCR_NO_UPDATE=1 in the job environment for every step that runs ocr, as the shared origin89-review skill's Open Code Review reference already requires for local runs.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions