Repository navigation
fix: pin pnpm/action-setup to its v6 commit - #30
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Advanced Run ID: 📒 Files selected for processing (3)
Limit details: You’ve used all 10 included reviews currently available. 📝 WalkthroughWalkthroughThe adoption instructions now require cargo deny and pinned-version zizmor checks before opening a pull request. They specify GH_TOKEN for online action-pin audits, note a limitation of offline audits, and describe how to handle findings. The check and release workflow templates update the pinned commit for pnpm/action-setup v6. Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Merge Risk: ⚪ Minimal · up to The workflow templates use the intended pnpm action version, and the adoption guidance documents the pre-PR checks. No material merge risk is established. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Usage-based review receipt
Note This review exceeded your plan’s limits and used usage-based reviews—free during trial, billed after paid activation unless disabled. Manage usage-based reviews. Comment |
Change
The check and release templates pinned
pnpm/action-setup@f520ece, which is the annotated tag object forv6, not a commit. Actions resolves it to commit0977fd9(v6.0.10), so the code that ran was genuine, but zizmor's onlineref-version-mismatchaudit fails on it, and every repo that copied the templates inherited the pin. The templates now pin0977fd99725f1db4007ccb2928dbb4e90d06cc86, the same code.docs/adopting.mdnow says to run zizmor withGH_TOKENso online audits run; the offline runs used for the adoption PRs missed this.Validation
git ls-remote https://github.com/pnpm/action-setupshowsrefs/tags/v6=f520eceandrefs/tags/v6^{}=0977fd9. Rendered copies of every template passactionlintand onlinezizmor 1.30.1 --min-severity medium(the OCR caller rendered with main's SHA).just checkpasses. The adopting repos' PRs carry the same repin.