Repository navigation
perf: cache per-model parts of select building and row parsing - #1814
Merged
Merged
Conversation
Since ruff 0.16.10 ruff format also rewrites Python code blocks in Markdown, so make pre-commit (and the git hook running it) reformatted README.md and the docs on every run.
Labelled column lists, row extraction plans and ORDER BY text clauses only depend on the model, alias and selected fields, yet were rebuilt on every query. Cache them (bounded lru caches) so repeated queries reuse them.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merging this PR will improve performance by 11.74%
Performance Changes
Tip Curious why performance improved? Comment Comparing 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The labelled column list, the row extraction plan and default ORDER BY text clauses only depend on the model, alias and selected fields, but were rebuilt for every query. They're now cached (bounded lru caches), and the row plan is shared between querysets instead of per queryset.
Small win: single-row reads (get, first, exists, get_or_none) are 2-6% faster, get on the wide model ~10%. The rest of a get() is SQLAlchemy statement/cache-key work and the DB round trip.
Based on #1813 (pre-commit hook fails on master without it), will rebase once that's merged.