Skip to content

Stop Descriptor and the back arrow doing each other's job #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oroderico merged 1 commit into from
Aug 16, 2026
Merged

Stop Descriptor and the back arrow doing each other's job #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion main/seedtool_app.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2108,7 +2108,14 @@ static void show_extended_keys(const char* mnemonic, const char* passphrase, con
}
items[count++] = "Descriptor";
const int selected = choose_menu_at("Extended public key", items, count, &cursor);
if (selected < 0 || (size_t)selected == count - 1) {
/* `count`, not `count - 1`: choose_menu_at returns the arrow as the
* index one past the last row - the slot the Back row used to occupy -
* so `count - 1` is the last real item instead. Here that item is
* "Descriptor", which made the two swap: picking Descriptor left the
* menu, and taking the arrow fell through to the else below and opened
* the descriptor. The other menus compare against a literal that
* already equals count, which is why this was the only one left. */
if (selected < 0 || (size_t)selected == count) {
return;
}
if (selected == 0) {
Expand Down