Repository navigation
fix: correct social sign-in, enterprise SSO, and directory sync integrations - #5
Open
jhickmanit wants to merge 1 commit into
Open
jhickmanit wants to merge 1 commit into
jhickmanit wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the social sign-in, enterprise SSO, generic protocol, government identity, directory sync, and agent identity integrations so their configuration matches what Ory Network accepts and the provider documentation on ory.com/docs.
Changes
pkce: force./oidc/callbackredirect URI, without the provider ID, because they force PKCE.given_nameis missing.messagesbody otherwise. Before, it returned 200 and never blocked a sign-in.aal2_acr_valuesand LoA URIs are corrected.Deployment notes
Validation
tsc --noEmit, and all registry entries parse.