Repository navigation
fix: place webhook integrations on every sign-in method and fix their handlers - #7
Open
jhickmanit wants to merge 2 commits into
Open
jhickmanit wants to merge 2 commits into
jhickmanit wants to merge 2 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: jhickmanit <jeff.hickman@ory.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the webhook-based CRM, analytics, consent, compliance, billing, SIEM, helpdesk, enrichment, and webhook infrastructure integrations with how Ory Actions run on Ory Network.
Changes
registration.after.password.hooksfollowed bysession. On Network the password list always containssession, so an action in the flow-wide list does not run for password sign-up. Each config aliases its password list, with YAML anchors, into theoidc,code,passkey, andwebauthnlists, so the actions run for every sign-in method.can_interruptis removed.base64://, because Ory Network rejectsfile://. Direct vendor calls useapi_keyorbasic_auth, because Ory Network does not send webhookheaders.metadata_admin, which the webhook context does not contain./stripe/webhookroute. Each Stripe event triggers a sync of the subscription state retrieved from Stripe.If-Match: *, so it creates new contacts again.external_id.createfor data streams and reads the IP fromTrue-Client-Ip.Deployment notes
Validation
tsc --noEmitpasses in every changed handler.