Repository navigation
fix: run verification, fraud, and MFA checks on every method and persist callbacks - #8
Open
jhickmanit wants to merge 2 commits into
Open
jhickmanit wants to merge 2 commits into
jhickmanit wants to merge 2 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: jhickmanit <jeff.hickman@ory.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the identity verification, fraud, MFA, SMS, and email integrations: hook placement, blocking responses, callback reliability, and courier configuration.
Changes
sessionlast. Each config aliases its password list, with YAML anchors, into theoidc,code,passkey, andwebauthnlists. Verification, fraud, and MFA checks therefore run for every sign-in method, not only password.messages[].messages[]shape.data.attributes.nameanddata.attributes.payload.data).Persona-Signaturewith a five-minute tolerance.PERSONA_HOSTED_URL.parse. A deny returns 403, and a challenge returnsrequired_aal: aal2. The registration check reports only.registration.beforelookup and uses the SDK’s typed enrollment and identity lookup responses, so successful lookups reach the phone-mismatch check.updated_attest and retry to avoid overwriting data written since the GET.request_configwithctx.bodyandctx.html_body.template_data.rpexample, the ID.me issuer, and Sift's hook placement and score scale are corrected.Deployment notes
INSTANTID_*_THRESHOLDvariables and exits at startup without them. The Socure callback returns 503 until its Ory credentials are set.EQUIFAX_PASS_DECISIONSdefault (APPROVE,PASS,ACCEPT) for your product. The custom UI message IDs are in the 9xxxxxx range.Validation
tsc --noEmitpasses in every changed handler, and all Jsonnet evaluates with go-jsonnet 0.21.