feat(codex): add native Lumen plugin package - #184
Merged
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
🚧 Files skipped from review as they are similar to previous changes (10)
📝 WalkthroughWalkthroughThe repository now distributes Lumen through a native Codex marketplace plugin. It adds plugin metadata, MCP configuration, skills, cross-platform launchers, writable binary storage, index health handling, installation checks, release validation, and updated documentation. ChangesCodex plugin distribution
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant Codex
participant LumenLauncher
participant PluginData
participant GitHubReleases
participant LumenBinary
Codex->>LumenLauncher: invoke MCP command
LumenLauncher->>PluginData: search for executable
LumenLauncher->>GitHubReleases: download versioned or latest asset
GitHubReleases-->>PluginData: return platform binary
LumenLauncher->>LumenBinary: execute with forwarded arguments
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
aeneasr
marked this pull request as ready for review
August 7, 2026 21:27
aeneasr
force-pushed
the
aeneasr/fix-codex-lumen-path
branch
from
August 8, 2026 20:42
28491a4 to
5a59bbe
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/test_run.sh`:
- Around line 151-154: Update resolved_version_from_plugin_manifest so ver is
declared separately before assigning the command-substitution result. Keep the
existing version extraction and v prefix unchanged, ensuring the assignment’s
exit status is preserved.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 7daeed30-b401-49ee-954f-37dc3e8665ce
📒 Files selected for processing (21)
.agents/plugins/marketplace.json.codex/INSTALL.md.github/workflows/ci.yml.gitignoreAGENTS.mdCLAUDE.mdREADME.mdinternal/release/metadata_test.goplugins/lumen/.codex-plugin/plugin.jsonplugins/lumen/.mcp.jsonplugins/lumen/mcp.jsonplugins/lumen/plugin.jsonplugins/lumen/scripts/runplugins/lumen/scripts/run.cmdplugins/lumen/skills/doctor/SKILL.mdplugins/lumen/skills/reindex/SKILL.mdrelease-please-config.jsonscripts/runscripts/run.cmdscripts/test_run.shscripts/test_run_windows.ps1
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 69-70: Add explicit read-only token permissions to both CI jobs:
set contents: read under semantic_e2e at .github/workflows/ci.yml lines 69-70
and under build at lines 141-148. No other job permissions need changing.
In @.github/workflows/release-please.yml:
- Around line 63-65: Update the actions/checkout step in the release workflow to
set persist-credentials to false alongside the existing ref configuration,
ensuring subsequent canary steps cannot access persisted GitHub token
credentials.
In `@cmd/hook_test.go`:
- Around line 387-394: Ensure the test store created in this setup is closed on
every exit path by immediately deferring s.Close() after store.New succeeds,
before calling SetMeta. Update the setup around store.New and SetMeta; preserve
the existing fatal error handling and avoid relying on a later explicit close.
In `@internal/embedder/failover.go`:
- Around line 236-244: Update the Embed request flow so the caller context is
passed through findNextHealthy to probeHealth, replacing probeHealth’s
context.Background() timeout base with that propagated context while retaining
the healthCheckTimeout deadline.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: b5f9a609-42b9-4e4c-9bc3-75c162ffe3a3
📒 Files selected for processing (21)
.github/workflows/ci.yml.github/workflows/release-please.ymlcmd/hook.gocmd/hook_test.gocmd/stdio.gocmd/stdio_test.gointernal/embedder/failover.gointernal/embedder/failover_test.gointernal/embedder/health.gointernal/index/index.gointernal/index/index_test.gointernal/release/artifact_smoke_test.gointernal/store/store.gopackage.jsonplugins/lumen/scripts/run.cmdplugins/lumen/skills/reindex/SKILL.mdscripts/run.cmdscripts/test_agent_installations.shscripts/test_run.shscripts/testdata/mcp_smoke_client/main.goscripts/verify_opencode_package.mjs
🚧 Files skipped from review as they are similar to previous changes (4)
- plugins/lumen/skills/reindex/SKILL.md
- plugins/lumen/scripts/run.cmd
- scripts/run.cmd
- scripts/test_run.sh
Addresses ShellCheck SC2155 flagged in review: `local ver="$(...)"` masks the command substitution's exit status. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The static workaround removes libpthread.dll.a, which is absent on the current windows-latest image and makes setup-mingw fail before the build step runs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
aeneasr
force-pushed
the
aeneasr/fix-codex-lumen-path
branch
from
August 11, 2026 06:53
6a16668 to
c6b509c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an isolated native Codex/Agent Plugins package with local marketplace metadata, MCP manifests, copied skills, and cross-platform launchers.
Updates launchers to honor
PLUGIN_ROOTand store downloaded binaries in writablePLUGIN_DATA, with release metadata parity and platform tests. Refreshes Codex installation and migration docs, and adds a Linux Codex plugin install smoke test to CI.Tests:
make test;bash scripts/test_run.sh;make lint.Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Tests