Rift o4d AJ changes#142
Merged
Merged
Conversation
… version was optimized for basic iteration structure. Also, the diagnostics file is now thorough.
…r to bypass the RIFT NR infrastructure and allows the user to use the new SXS interface, where they do not provide the NR files in h5 format. While writing the SXS function, I ran into a number of bugs that I reported to the SXS people (here:sxs-collaboration/sxs#188) and as such I have hardcoded a few settings to avoid those bugs. As SXS developers fix those bugs, we should remove these hardcoded settings. I have compared the LVK format function with NR infrastructure frame writer for multiple NR files, and they match within a time sample.
…they do not provide modes, this calls the waveform at 5 different inclinations and phases to compute modes. This approach is copied from the hlmoft_IMRPv2_dict function in lalsimutils. Has been tested on 3 cases with satisfactory performance, however it needs thorough testing. Also, we need to implement changes in factored_likelihood and util_RIFT_pseudopipe so this can be used.
Owner
|
CI hitting a module-import error b/c pyEPFE not installed; can you put a manual block on it? |
… name than main iterations that this was not taking into account
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plot_RIFT.py: made changes so that it handles subdags better. The earlier version was optimized for basic iteration structure. Also, the diagnostics file is now thorough.
util_LALNRWriteFrame.py: Added NR frame writer. This version allows the user to bypass the RIFT NR infrastructure and allows the user to use the new SXS interface, where they do not provide the NR files in h5 format. While writing the SXS function, I ran into a number of bugs that I reported to the SXS people (here:sxs-collaboration/sxs#188) and as such I have hardcoded a few settings to avoid those bugs. As SXS developers fix those bugs, we should remove these hardcoded settings. I have compared the LVK format function with NR infrastructure frame writer for multiple NR files, and they match within a time sample.
EFPE.py: implemented the EFPE (eccentric+precessing PN) model. Since they do not provide modes, this calls the waveform at 5 different inclinations and phases to compute modes. This approach is copied from the hlmoft_IMRPv2_dict function in lalsimutils. Has been tested on 3 cases with satisfactory performance, however it needs thorough testing. Also, we need to implement changes in factored_likelihood and util_RIFT_pseudopipe so this can be used.