Skip to content

fix(controller): add retry-on-conflict to MimirRule reconciler - #150

Merged
Hy3n4 merged 2 commits into
mainfrom
fix/mimirrule-retry-on-conflict
Feb 21, 2026
Merged

fix(controller): add retry-on-conflict to MimirRule reconciler#150
Hy3n4 merged 2 commits into
mainfrom
fix/mimirrule-retry-on-conflict

Conversation

@Hy3n4

@Hy3n4 Hy3n4 commented Feb 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Wrap all r.Update() and r.Status().Update() calls in retry.RetryOnConflict with re-fetch
  • Prevents transient "the object has been modified" errors when the SLO controller and MimirRule controller race to modify the same resource
  • Follows standard Kubernetes controller pattern for optimistic concurrency handling

Fixes noisy but harmless conflict errors observed in production logs.

…vent transient errors

Signed-off-by: Hy3n4 <hy3nk4@gmail.com>
@github-actions github-actions Bot added the bug Something isn't working label Feb 21, 2026
@Hy3n4
Hy3n4 merged commit 0a460af into main Feb 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant